fixup! proof: Add stxo exclusion proof verification

Author: gijswijs

proof/taproot.go

@@ -25,6 +25,10 @@ var (
 	ErrInvalidCommitmentProof = errors.New(
 		"invalid Taproot Asset commitment proof",
 	)
+
+	ErrStxoInputProofMissing = errors.New(
+		"missing STXO input proof for Taproot Asset commitment",
+	)
 )
 
 // CommitmentProof represents a full commitment proof for an asset. It can

proof/verifier.go

@@ -193,7 +193,7 @@ func (p *Proof) verifyInclusionProof() (*commitment.TapCommitment, error) {
 
 	if needStxoProofs && !hasStxoProofs {
 		return nil, fmt.Errorf("%w: missing STXO proofs",
-			ErrInvalidCommitmentProof)
+			ErrStxoInputProofMissing)
 	}
 
 	// We ignore the STXO proofs if the proof signals version 0, or if there
@@ -237,7 +237,7 @@ func (p *Proof) verifyInclusionProof() (*commitment.TapCommitment, error) {
 	// missing proofs for those outputs.
 	if len(p2trOutputs) > 0 {
 		return nil, fmt.Errorf("%w: missing inclusion proof",
-			ErrInvalidCommitmentProof)
+			ErrStxoInputProofMissing)
 	}
 
 	return v0Commitment, nil
@@ -303,7 +303,7 @@ func (p *Proof) verifyExclusionProofs() (*commitment.TapCommitmentVersion,
 
 	if needStxoProofs && !hasStxoProofs {
 		return nil, fmt.Errorf("%w: missing STXO proofs",
-			ErrInvalidCommitmentProof)
+			ErrStxoInputProofMissing)
 	}
 
 	// We ignore the STXO proofs if the proof signals version 0, or if there
@@ -411,7 +411,7 @@ func (p *Proof) verifyV1ExclusionProofs(p2trOutputs fn.Set[uint32]) error {
 	// missing proofs for those outputs.
 	if len(p2trOutputsSTXOs) > 0 {
 		return fmt.Errorf("%w: missing STXO proofs",
-			ErrInvalidCommitmentProof)
+			ErrStxoInputProofMissing)
 	}
 
 	return nil

proof/verifier_test.go

@@ -329,7 +329,7 @@ func TestVerifyV1InclusionProof(t *testing.T) {
 
 			return p
 		},
-		expectedErr: ErrInvalidCommitmentProof,
+		expectedErr: ErrStxoInputProofMissing,
 	}, {
 		name: "invalid v0 proof",
 		makeProof: func(t *testing.T) []*Proof {
@@ -363,7 +363,7 @@ func TestVerifyV1InclusionProof(t *testing.T) {
 
 			return p
 		},
-		expectedErr:         ErrInvalidCommitmentProof,
+		expectedErr:         ErrStxoInputProofMissing,
 		expectedErrContains: "missing STXO proofs",
 	}, {
 		name: "correct v0 and v1 proofs",
@@ -439,7 +439,7 @@ func TestVerifyV1InclusionProof(t *testing.T) {
 
 			return p
 		},
-		expectedErr:         ErrInvalidCommitmentProof,
+		expectedErr:         ErrStxoInputProofMissing,
 		expectedErrContains: "missing inclusion proof",
 	}, {
 		name: "multiple valid stxo proofs",
@@ -602,7 +602,7 @@ func TestVerifyV1ExclusionProof(t *testing.T) {
 
 			return p
 		},
-		expectedErr:         ErrInvalidCommitmentProof,
+		expectedErr:         ErrStxoInputProofMissing,
 		expectedErrContains: "missing STXO proofs",
 	}, {
 		name: "correct v1 exclusion proof",
@@ -757,7 +757,7 @@ func TestVerifyV1ExclusionProof(t *testing.T) {
 
 			return p
 		},
-		expectedErr:         ErrInvalidCommitmentProof,
+		expectedErr:         ErrStxoInputProofMissing,
 		expectedErrContains: "missing STXO proofs",
 	}}