Skip to content

Conversation

@tnull
Copy link
Contributor

@tnull tnull commented Oct 20, 2025

We previously dropped cfg(async_payments) but didn't drop the actual cargo test call from our CI. Here we do that.

We previously dropped `cfg(async_payments)` but didn't drop the actual
`cargo test` call from our CI. Here we do that.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Oct 20, 2025

👋 I see @jkczyz was un-assigned.
If you'd like another reviewer assignment, please click here.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.78%. Comparing base (05f2848) to head (2d7a53f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4165   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files         180      180           
  Lines      137004   137004           
  Branches   137004   137004           
=======================================
  Hits       121642   121642           
- Misses      12538    12546    +8     
+ Partials     2824     2816    -8     
Flag Coverage Δ
fuzzing 20.95% <ø> (ø)
tests 88.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@valentinewallace valentinewallace removed the request for review from jkczyz October 20, 2025 13:53
@tnull
Copy link
Contributor Author

tnull commented Oct 21, 2025

Simple enough. CI failures are unrelated.

@tnull tnull merged commit 7f20d47 into lightningdevkit:main Oct 21, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants