Rewrite sync bg processor #3820
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @TheBlueMatt was un-assigned. |
joostjager
commented
Jun 2, 2025
| @@ -340,6 +344,47 @@ impl Sleeper { | |||
| } | |||
| } | |||
|
|
|||
| pub struct Sleep { | |||
There was a problem hiding this comment.
There is already Sleeper in the repository, but from_single_future takes a future and isn't just a sleep.
No need to make it complicated using async tasks?
joostjager
force-pushed
the
rewrite-sync-bg-processor
branch
from
27a8ad2 to
74f5af1
Compare
joostjager
commented
Jun 2, 2025
| } | ||
| }, | ||
| |_| Instant::now(), | ||
| |time: &Instant, dur| time.elapsed().as_secs() > dur, |
There was a problem hiding this comment.
Is there a reason why this wasn't done in the first place? All the timer checks seem to be non-blocking.
joostjager
commented
Jun 2, 2025
| let waker_clone = waker.clone(); | ||
|
|
||
| thread::spawn(move || { | ||
| thread::sleep(duration); |
There was a problem hiding this comment.
Chatgpt implementation - probably a lot wrong about it.
|
@TheBlueMatt is this a viable approach? |
|
🔔 1st Reminder Hey @TheBlueMatt! This PR has been waiting for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt to rewrite the sync bg processor so that it uses the async version of it. Prepares for #3778 where the
Persistertrait is made async, and wouldn't be callable from the sync bg processor anymore.Additionally it allows us to get rid of the
define_run_bodymacro.Various open ends marked by comments on this PR.