-
Notifications
You must be signed in to change notification settings - Fork 410
Convert file-level rustfmt skip to fn level skips #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
joostjager
wants to merge
4
commits into
lightningdevkit:main
Choose a base branch
from
joostjager:rustfmt-skip-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,47 @@ | ||
#![cfg_attr(rustfmt, rustfmt_skip)] | ||
mod utils; | ||
pub mod msg_accept_channel; | ||
pub mod msg_accept_channel_v2; | ||
pub mod msg_announcement_signatures; | ||
pub mod msg_channel_announcement; | ||
pub mod msg_channel_details; | ||
pub mod msg_channel_ready; | ||
pub mod msg_channel_reestablish; | ||
pub mod msg_channel_update; | ||
pub mod msg_closing_signed; | ||
pub mod msg_commitment_signed; | ||
pub mod msg_decoded_onion_error_packet; | ||
pub mod msg_error_message; | ||
pub mod msg_funding_created; | ||
pub mod msg_channel_ready; | ||
pub mod msg_funding_signed; | ||
pub mod msg_gossip_timestamp_filter; | ||
pub mod msg_init; | ||
pub mod msg_node_announcement; | ||
pub mod msg_open_channel; | ||
pub mod msg_open_channel_v2; | ||
pub mod msg_ping; | ||
pub mod msg_pong; | ||
pub mod msg_query_channel_range; | ||
pub mod msg_query_short_channel_ids; | ||
pub mod msg_reply_channel_range; | ||
pub mod msg_reply_short_channel_ids_end; | ||
pub mod msg_revoke_and_ack; | ||
pub mod msg_shutdown; | ||
pub mod msg_splice_ack; | ||
pub mod msg_splice_init; | ||
pub mod msg_splice_locked; | ||
pub mod msg_stfu; | ||
pub mod msg_tx_abort; | ||
pub mod msg_tx_ack_rbf; | ||
pub mod msg_tx_add_input; | ||
pub mod msg_tx_add_output; | ||
pub mod msg_tx_complete; | ||
pub mod msg_tx_init_rbf; | ||
pub mod msg_tx_remove_input; | ||
pub mod msg_tx_remove_output; | ||
pub mod msg_tx_signatures; | ||
pub mod msg_update_add_htlc; | ||
pub mod msg_update_fail_htlc; | ||
pub mod msg_update_fail_malformed_htlc; | ||
pub mod msg_update_fee; | ||
pub mod msg_update_fulfill_htlc; | ||
pub mod msg_channel_reestablish; | ||
pub mod msg_decoded_onion_error_packet; | ||
pub mod msg_channel_announcement; | ||
pub mod msg_node_announcement; | ||
pub mod msg_channel_update; | ||
pub mod msg_query_short_channel_ids; | ||
pub mod msg_reply_channel_range; | ||
pub mod msg_error_message; | ||
pub mod msg_warning_message; | ||
pub mod msg_channel_details; | ||
pub mod msg_open_channel_v2; | ||
pub mod msg_accept_channel_v2; | ||
pub mod msg_tx_add_input; | ||
pub mod msg_tx_add_output; | ||
pub mod msg_tx_remove_input; | ||
pub mod msg_tx_remove_output; | ||
pub mod msg_tx_complete; | ||
pub mod msg_tx_signatures; | ||
pub mod msg_tx_init_rbf; | ||
pub mod msg_tx_ack_rbf; | ||
pub mod msg_tx_abort; | ||
pub mod msg_stfu; | ||
pub mod msg_splice_init; | ||
pub mod msg_splice_ack; | ||
pub mod msg_splice_locked; | ||
mod utils; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was put here deliberately as we opted against running
rustfmt
on autogenerated files. We need to fix it either way, likely just revert it to include the skip.