Conversation
|
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| outgoing_cltv_value: u32, | ||
| }, | ||
| // This should only be used for nested Trampoline onions | ||
| TrampolineForward { |
There was a problem hiding this comment.
Rather than creating this variant, we could also add an enum inside the Forward variant that would describe the forwarding mechanism to be either based short_channel_id or outgoing_node_id.
| }; | ||
|
|
||
| let carol_payload_hex = slice_to_hex(&trampoline_payloads[0].encode()); | ||
| println!("Carol Payload Hex: {}", carol_payload_hex); |
There was a problem hiding this comment.
if this general approach has a concept ACK, I'd remove the print statements from the unit test
TheBlueMatt
deleted the
arik/trampoline/2024-02-trampoline-onion-construction-vectors
branch
|
Why did this get closed? |
|
I accidentally created the branch on the |
3 participants
This PR builds on top of #2756, and adds a method to construct variable-length onion packets.
That method is used to check out bound Trampoline construction and nesting against test vectors.