Skip to content

Create Taproot feature and introduce signer type enum #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arik-so wants to merge 3 commits into from
Closed

Create Taproot feature and introduce signer type enum #2289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65bf87b
Add Taproot feature support.
arik-so May 7, 2023
e369bbf
Create ChannelSignerType enum.
arik-so May 15, 2023
b8ee6bd
Make as_ecdsa return types optional.
arik-so May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lightning/src/ln/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ mod sealed {
// Byte 2
BasicMPP | Wumbo | AnchorsZeroFeeHtlcTx,
// Byte 3
ShutdownAnySegwit,
ShutdownAnySegwit | Taproot,
// Byte 4
OnionMessages,
// Byte 5
Expand All @@ -152,7 +152,7 @@ mod sealed {
// Byte 2
BasicMPP | Wumbo | AnchorsZeroFeeHtlcTx,
// Byte 3
ShutdownAnySegwit,
ShutdownAnySegwit | Taproot,
// Byte 4
OnionMessages,
// Byte 5
Expand Down Expand Up @@ -198,7 +198,7 @@ mod sealed {
// Byte 2
AnchorsZeroFeeHtlcTx,
// Byte 3
,
Taproot,
// Byte 4
,
// Byte 5
Expand Down Expand Up @@ -384,6 +384,9 @@ mod sealed {
define_feature!(27, ShutdownAnySegwit, [InitContext, NodeContext],
"Feature flags for `opt_shutdown_anysegwit`.", set_shutdown_any_segwit_optional,
set_shutdown_any_segwit_required, supports_shutdown_anysegwit, requires_shutdown_anysegwit);
define_feature!(31, Taproot, [InitContext, NodeContext, ChannelTypeContext],
Copy link

@ariard ariard May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extension-bolt should be updated to mark INC: https://github.com/lightning/bolts/pull/995/files#diff-5005c17d0f8887bea09bff54878cb0bdb2bb3d632b1813a2622560e842a0d322R362

Copy link
Contributor

@dunxen dunxen Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a TODO(taproot) to the module docs above to remember to document support for simple taproot channels when the time comes?

"Feature flags for `option_taproot`.", set_taproot_optional,
set_taproot_required, supports_taproot, requires_taproot);
define_feature!(39, OnionMessages, [InitContext, NodeContext],
"Feature flags for `option_onion_messages`.", set_onion_messages_optional,
set_onion_messages_required, supports_onion_messages, requires_onion_messages);
Expand Down