Skip to content

Implement Hash for ConfirmationTarget #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benthecarman
Copy link
Contributor

@benthecarman benthecarman commented Nov 4, 2022

In the ldk sample ConfirmationTarget is remade so it can be used in a HashMap. This should allow for a simplification in the sample node and likely other projects.

@codecov-commenter
Copy link

Codecov Report

Base: 90.78% // Head: 90.76% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (83dcd39) compared to base (e55e0d5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.03%     
==========================================
  Files          87       87              
  Lines       47604    47604              
  Branches    47604    47604              
==========================================
- Hits        43218    43207      -11     
- Misses       4386     4397      +11     
Impacted Files Coverage Δ
lightning/src/chain/chaininterface.rs 95.65% <0.00%> (ø)
lightning/src/chain/onchaintx.rs 94.57% <0.00%> (-0.44%) ⬇️
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (-0.12%) ⬇️
lightning/src/ln/channelmanager.rs 85.38% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 8f525c4 into lightningdevkit:main Nov 4, 2022
@benthecarman benthecarman deleted the hash-ConfirmationTarget branch November 4, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants