fixup: do not immediately queue broadcast on transactions_confirmed, instead mark it as should_broadcast_commitment for later queueing

martinsaposnic · martinsaposnic · commit 61d9c28c4270 · 2025-09-26T13:18:31.000-03:00
diff --git a/lightning/src/chain/channelmonitor.rs b/lightning/src/chain/channelmonitor.rs
@@ -5285,12 +5285,7 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {
 
 		if self.is_manual_broadcast && !funding_seen_before && self.funding_seen_onchain && self.holder_tx_signed
 		{
-			self.queue_latest_holder_commitment_txn_for_broadcast(
-				&broadcaster,
-				fee_estimator,
-				logger,
-				true,
-			);
+			should_broadcast_commitment = true;
 		}
 		'tx_iter: for tx in &txn_matched {
 			let txid = tx.compute_txid();

Original file line number	Diff line number	Diff line change
`@@ -5285,12 +5285,7 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {`
`5285`	`5285`
`5286`	`5286`	`if self.is_manual_broadcast && !funding_seen_before && self.funding_seen_onchain && self.holder_tx_signed`
`5287`	`5287`	`{`
`5288`		`- self.queue_latest_holder_commitment_txn_for_broadcast(`
`5289`		`- &broadcaster,`
`5290`		`- fee_estimator,`
`5291`		`- logger,`
`5292`		`- true,`
`5293`		`- );`
	`5288`	`+ should_broadcast_commitment = true;`
`5294`	`5289`	`}`
`5295`	`5290`	`'tx_iter: for tx in &txn_matched {`
`5296`	`5291`	`let txid = tx.compute_txid();`