Skip to content

Export trait impls in FFI #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Export trait impls in FFI #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bindings/ldk_node.udl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,7 @@ dictionary RouteHintHop {
RoutingFees fees;
};

[Traits=(Debug, Display, Eq)]
interface Bolt11Invoice {
[Throws=NodeError, Name=from_str]
constructor([ByRef] string invoice_str);
Expand Down
2 changes: 1 addition & 1 deletion src/ffi/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ impl From<lightning::routing::router::RouteHintHop> for RouteHintHop {
/// Represents a syntactically and semantically correct lightning BOLT11 invoice.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Bolt11Invoice {
pub inner: LdkBolt11Invoice,
pub(crate) inner: LdkBolt11Invoice,
}

impl Bolt11Invoice {
Expand Down
1 change: 1 addition & 0 deletions src/payment/unified_qr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ impl UnifiedQrPayment {
/// [BIP 21]: https://github.com/bitcoin/bips/blob/master/bip-0021.mediawiki
/// [`PaymentId`]: lightning::ln::channelmanager::PaymentId
/// [`Txid`]: bitcoin::hash_types::Txid
#[derive(Debug)]
pub enum QrPaymentResult {
/// An on-chain payment.
Onchain {
Expand Down
Loading