Skip to content

Commit b3e89c6

Browse files
committed
Remove erroneous debug_assert when handling PaymentForwarded
Recent LDK changes made `skimmed_fee_msat` a required field of the LSPS service handler's `payment_forwarded` API, which seemed reasonable given that the field is available since LDK 0.0.122. However, when updating LDK Node we introduced a `debug_assert` that checked the field to be *always* set, which is wrong, as it's only set post-0.0.122 *if* there was some fee skimmed. Here we fix this oversight.
1 parent 121dadb commit b3e89c6

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

src/event.rs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1289,16 +1289,10 @@ where
12891289
}
12901290

12911291
if let Some(liquidity_source) = self.liquidity_source.as_ref() {
1292-
if let Some(skimmed_fee_msat) = skimmed_fee_msat {
1293-
liquidity_source
1294-
.handle_payment_forwarded(next_channel_id, skimmed_fee_msat)
1295-
.await;
1296-
} else {
1297-
debug_assert!(
1298-
false,
1299-
"We expect skimmed_fee_msat to be set since LDK 0.0.122"
1300-
);
1301-
}
1292+
let skimmed_fee_msat = skimmed_fee_msat.unwrap_or(0);
1293+
liquidity_source
1294+
.handle_payment_forwarded(next_channel_id, skimmed_fee_msat)
1295+
.await;
13021296
}
13031297

13041298
let event = Event::PaymentForwarded {

0 commit comments

Comments
 (0)