phoenix handle null channels

Author: ntheile

bindings/lni_nodejs/index.d.ts

@@ -3,237 +3,6 @@
 
 /* auto-generated by NAPI-RS */
 
-export interface PhoenixdConfig {
-  url: string
-  password: string
-  socks5Proxy?: string
-  acceptInvalidCerts?: boolean
-  httpTimeout?: number
-}
-export interface PhoenixdNode {
-  config: PhoenixdConfig
-}
-export interface Bolt11Resp {
-  amountSat: number
-  paymentHash: string
-  serialized: string
-}
-export interface PhoenixPayInvoiceResp {
-  amountSat: number
-  routingFeeSat: number
-  paymentId: string
-  paymentHash: string
-  preimage: string
-}
-export interface ClnConfig {
-  url: string
-  rune: string
-  socks5Proxy?: string
-  acceptInvalidCerts?: boolean
-  httpTimeout?: number
-}
-export interface ClnNode {
-  config: ClnConfig
-}
-export interface LndConfig {
-  url: string
-  macaroon: string
-  socks5Proxy?: string
-  acceptInvalidCerts?: boolean
-  httpTimeout?: number
-}
-export interface LndNode {
-  config: LndConfig
-}
-export const enum InvoiceType {
-  Bolt11 = 'Bolt11',
-  Bolt12 = 'Bolt12'
-}
-export interface TlvRecord {
-  type: number
-  value: string
-}
-export interface NodeInfo {
-  alias: string
-  color: string
-  pubkey: string
-  network: string
-  blockHeight: number
-  blockHash: string
-  sendBalanceMsat: number
-  receiveBalanceMsat: number
-  feeCreditBalanceMsat: number
-  unsettledSendBalanceMsat: number
-  unsettledReceiveBalanceMsat: number
-  pendingOpenSendBalance: number
-  pendingOpenReceiveBalance: number
-}
-export interface Transaction {
-  type: string
-  invoice: string
-  description: string
-  descriptionHash: string
-  preimage: string
-  paymentHash: string
-  amountMsats: number
-  feesPaid: number
-  createdAt: number
-  expiresAt: number
-  settledAt: number
-  payerNote?: string
-  externalId?: string
-}
-export interface NodeConnectionInfo {
-  pubkey: string
-  address: string
-  port: number
-}
-export interface Channel {
-  localBalance: number
-  localSpendableBalance: number
-  remoteBalance: number
-  id: string
-  remotePubkey: string
-  fundingTxId: string
-  fundingTxVout: number
-  active: boolean
-  public: boolean
-  internalChannel: string
-  confirmations: number
-  confirmationsRequired: number
-  forwardingFeeBaseMsat: number
-  unspendablePunishmentReserve: number
-  counterpartyUnspendablePunishmentReserve: number
-  error: string
-  isOutbound: boolean
-}
-export interface NodeStatus {
-  isReady: boolean
-  internalNodeStatus: string
-}
-export interface ConnectPeerRequest {
-  pubkey: string
-  address: string
-  port: number
-}
-export interface OpenChannelRequest {
-  pubkey: string
-  amountMsats: number
-  public: boolean
-}
-export interface OpenChannelResponse {
-  fundingTxId: string
-}
-export interface CloseChannelRequest {
-  channelId: string
-  nodeId: string
-  force: boolean
-}
-export interface UpdateChannelRequest {
-  channelId: string
-  nodeId: string
-  forwardingFeeBaseMsat: number
-  maxDustHtlcExposureFromFeeRateMultiplier: number
-}
-export interface CloseChannelResponse {
-  
-}
-export interface PendingBalanceDetails {
-  channelId: string
-  nodeId: string
-  amountMsats: number
-  fundingTxId: string
-  fundingTxVout: number
-}
-export interface OnchainBalanceResponse {
-  spendable: number
-  total: number
-  reserved: number
-  pendingBalancesFromChannelClosures: number
-  pendingBalancesDetails: Array<PendingBalanceDetails>
-  internalBalances: string
-}
-export interface PeerDetails {
-  nodeId: string
-  address: string
-  isPersisted: boolean
-  isConnected: boolean
-}
-export interface LightningBalanceResponse {
-  totalSpendable: number
-  totalReceivable: number
-  nextMaxSpendable: number
-  nextMaxReceivable: number
-  nextMaxSpendableMpp: number
-  nextMaxReceivableMpp: number
-}
-export interface PayInvoiceResponse {
-  paymentHash: string
-  preimage: string
-  feeMsats: number
-}
-export interface PayKeysendResponse {
-  fee: number
-}
-export interface BalancesResponse {
-  onchain: OnchainBalanceResponse
-  lightning: LightningBalanceResponse
-}
-export interface PaymentFailedEventProperties {
-  transaction: Transaction
-  reason: string
-}
-export interface ListTransactionsParams {
-  from: number
-  limit: number
-  paymentHash?: string
-}
-export interface CreateInvoiceParams {
-  invoiceType: InvoiceType
-  amountMsats?: number
-  offer?: string
-  description?: string
-  descriptionHash?: string
-  expiry?: number
-  rPreimage?: string
-  isBlinded?: boolean
-  isKeysend?: boolean
-  isAmp?: boolean
-  isPrivate?: boolean
-}
-export interface PayCode {
-  offerId: string
-  bolt12: string
-  label?: string
-  active?: boolean
-  singleUse?: boolean
-  used?: boolean
-}
-export interface PayInvoiceParams {
-  invoice: string
-  feeLimitMsat?: number
-  feeLimitPercentage?: number
-  timeoutSeconds?: number
-  amountMsats?: number
-  maxParts?: number
-  firstHopPubkey?: string
-  lastHopPubkey?: string
-  allowSelfPayment?: boolean
-  isAmp?: boolean
-}
-export interface OnInvoiceEventParams {
-  paymentHash: string
-  pollingDelaySec: number
-  maxPollingSec: number
-}
-export interface Payment {
-  paymentId: string
-  circId: string
-  round: number
-  relayFingerprint: string
-  updatedAt: number
-  amountMsats: number
-}
 export declare class PhoenixdNode {
   constructor(config: PhoenixdConfig)
   getUrl(): string
@@ -243,7 +12,7 @@ export declare class PhoenixdNode {
   createInvoice(params: CreateInvoiceParams): Transaction
   payInvoice(params: PayInvoiceParams): PayInvoiceResponse
   getOffer(): PayCode
-  lookupInvoice(paymentHash: string): Transaction
+  lookupInvoice(params: LookupInvoiceParams): Transaction
   payOffer(offer: string, amountMsats: number, payerNote?: string | undefined | null): PayInvoiceResponse
   listTransactions(params: ListTransactionsParams): Array<Transaction>
   onInvoiceEvents(params: OnInvoiceEventParams, callback: (arg0: string, arg1?: Transaction | undefined | null) => void): void
@@ -259,7 +28,7 @@ export declare class ClnNode {
   getOffer(search?: string | undefined | null): PayCode
   listOffers(search?: string | undefined | null): Array<PayCode>
   payOffer(offer: string, amountMsats: number, payerNote?: string | undefined | null): PayInvoiceResponse
-  lookupInvoice(paymentHash: string): Transaction
+  lookupInvoice(params: LookupInvoiceParams): Transaction
   listTransactions(params: ListTransactionsParams): Array<Transaction>
   decode(str: string): string
   onInvoiceEvents(params: OnInvoiceEventParams, callback: (arg0: string, arg1?: Transaction | undefined | null) => void): void
@@ -275,7 +44,7 @@ export declare class LndNode {
   getOffer(search?: string | undefined | null): PayCode
   listOffers(search?: string | undefined | null): Array<PayCode>
   payOffer(offer: string, amountMsats: number, payerNote?: string | undefined | null): PayInvoiceResponse
-  lookupInvoice(paymentHash: string): Transaction
+  lookupInvoice(params: LookupInvoiceParams): Transaction
   listTransactions(params: ListTransactionsParams): Array<Transaction>
   decode(str: string): string
   onInvoiceEvents(params: OnInvoiceEventParams, callback: (arg0: string, arg1?: Transaction | undefined | null) => void): void

bindings/lni_nodejs/index.js

@@ -310,9 +310,8 @@ if (!nativeBinding) {
   throw new Error(`Failed to load native binding`)
 }
 
-const { InvoiceType, PhoenixdNode, ClnNode, LndNode } = nativeBinding
+const { PhoenixdNode, ClnNode, LndNode } = nativeBinding
 
-module.exports.InvoiceType = InvoiceType
 module.exports.PhoenixdNode = PhoenixdNode
 module.exports.ClnNode = ClnNode
 module.exports.LndNode = LndNode

crates/lni/phoenixd/api.rs

@@ -73,8 +73,8 @@ pub fn get_info(config: &PhoenixdConfig) -> Result<NodeInfo, ApiError> {
         network: "bitcoin".to_string(),
         block_height: 0,
         block_hash: "".to_string(),
-        send_balance_msat: info.channels[0].balance_sat * 1000,
-        receive_balance_msat: info.channels[0].inbound_liquidity_sat * 1000,
+        send_balance_msat: info.channels.first().map_or(0, |c| c.balance_sat * 1000),
+        receive_balance_msat: info.channels.first().map_or(0, |c| c.inbound_liquidity_sat * 1000),
         fee_credit_balance_msat: balance.fee_credit_sat * 1000,
         ..Default::default()
     };