Skip to content

Conversation

@andydlindsay
Copy link
Collaborator

@andydlindsay andydlindsay commented Jun 6, 2023

  • Use concurrently to start sass in watch mode and run nodemon
  • Bump packages to latest versions except concurrently and chalk as the latest versions aren't compatible with older Node versions and/or CommonJS syntax
  • Tested with Node versions 14, 16, and 18

@andydlindsay andydlindsay self-assigned this Jun 6, 2023
@FrancisBourgouin
Copy link
Contributor

Sounds great! A little over engineered (is that for the purpose of showing them more helper function actions?)

@andydlindsay
Copy link
Collaborator Author

I don't think there's any learning outcomes from this code. This PR is trying to simplify the process of how/when the SCSS gets compiled. The student will not need to edit or understand this code to make their project work.

Are there suggestions to simplify this code?

@FrancisBourgouin
Copy link
Contributor

FrancisBourgouin commented Jul 6, 2023

I was thinking of just using plain sass --watch + nodemon with a package like concurently (https://github.com/open-cli-tools/concurrently)

  • add concurently to dependencies
  • npm run server => nodemon ./bin/www
  • npm run sass => sass --watch ./styles ./public/styles
  • npm run dev => concurrently "npm:server" "npm:sass"

@andydlindsay andydlindsay changed the title Adds sass compile function Compile Sass on Server Start Jan 10, 2025
Copy link
Contributor

@FrancisBourgouin FrancisBourgouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested locally!

@FrancisBourgouin FrancisBourgouin merged commit d5db147 into master Jan 13, 2025
@FrancisBourgouin FrancisBourgouin deleted the andydlindsay-sass-on-start branch February 7, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants