Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for bintray sbt plugin #158

Closed
gkossakowski opened this issue Jan 14, 2015 · 9 comments
Closed

Support for bintray sbt plugin #158

gkossakowski opened this issue Jan 14, 2015 · 9 comments

Comments

@gkossakowski
Copy link

Projects using bintray sbt plugin cannot be built by dbuild at the moment. The problem has been originally reported as sbt/sbt-testng#4. @cunei has investigated it and concluded that dbuild needs special support for bintray plugin:

Yep. The bintray-sbt plugin, according to its source, overrides publishTo, publish, publishConfiguration, and credentials (and other stuff). Subsequently, dbuild overwrites publishTo (so that the artifacts end up in its own cache), but assumes publish will be unchanged and will actually publish to the rewritten publishTo. So this won't work, and dbuild will need to work around that, either by disabling the bintray plugin or by rewriting publish in order to set it /again/ to the default one, which will probably do the trick.

Until explicit support for bintray arrives we'll need to get rid of bintray settings by forking projects using it. See for example gkossakowski/sbt-testng-interface@41b39ec.

I set priority to medium because this issue forces us to keep forks of projects we are building around.

@SethTisue
Copy link
Contributor

this hasn't been causing me any trouble in the Scala community build in the past year. maybe not an issue anymore

well, with perhaps one exception: scala/community-build#290

cunei pushed a commit to cunei/dbuild that referenced this issue Nov 2, 2016
This should fix lightbend-labs#158, and provide support for
Bintray-enabled projects without workarounds.
@cunei cunei closed this as completed in 7ef6be7 Nov 5, 2016
@SethTisue
Copy link
Contributor

@cunei I'm seeing this in ScalaMock here: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1055/consoleFull, even with dbuild 0.9.7-RC1

ScalaMock is not the only project in the community build that uses bintray-sbt 0.3.0. I'm not sure what the difference is

SethTisue added a commit to SethTisue/ScalaMock that referenced this issue Dec 6, 2016
because even dbuild 0.9.7-RC1 doesn't seem to fix
lightbend-labs/dbuild#158
in every case. not in this one anyway
@SethTisue
Copy link
Contributor

akka-http, too, at https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1056/consoleFull:

[akka-http] Running "compile" in: akka-parsing
[akka-http] [warn] Credentials file /home/jenkins/.bintray/.credentials does not exist
[akka-http] Publishing: akka-parsing
[akka-http] bintray-sbt requires your bintray credentials.
[akka-http] Enter bintray username: java.util.NoSuchElementException: None.get

@SethTisue
Copy link
Contributor

hit this twice more recently — had to fork akka-sse and akka-contrib-extras to get around it

@SethTisue
Copy link
Contributor

hit this again with scalameta in scala/community-build#472

the bintray plugin was long unmaintained, but was recently moved to the sbt org. perhaps there's a possibility of addressing this now from the plugin's end

@dwijnand
Copy link
Contributor

Strictly WRT the None.get case I think it should be possible to change sbt-bintray, not by special-casing sbt-bintray in dbuild - an acceptable variant on sbt/sbt-bintray#69 would suffice (see my comments at the end).

@SethTisue
Copy link
Contributor

Strictly WRT the None.get case I think it should be possible to change sbt-bintray, not by special-casing sbt-bintray in dbuild

yeah but based on @cunei's remarks (quoted by Grzegorz at the top of this ticket), the problem is more fundamental than that, I think — working around the None.get would likely only expose further problems...?

this is getting to be a bigger and bigger problem for the community build, as more projects adopt Bintray — we're up to nine forked projects over this one issue.

is there any chance you guys could give this issue a look and arrive at a fix or workaround that doesn't require forking projects? whether the fix is in dbuild or sbt-bintray or some combination...? (or are you maxed out until sbt 1.0 is out?)

@dwijnand
Copy link
Contributor

I've put it on my overflow list, hopefully I can carve out some time to work on it. But generally, yeah, we're all out on sbt 1 atm.

@SethTisue
Copy link
Contributor

I'm finding that the following combination works:

  • dbuild 0.9.9
  • sbt-bintray 0.5.1
  • extra.options: ["-Dbintray.user=dummy", "-Dbintray.pass=dummy"]

@cunei so, you can close this ticket 🎉

@cunei cunei closed this as completed Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants