Skip to content

Commit 69ba74d

Browse files
chore: update configuration
_This PR is created by sync and will be force-pushed daily. Overwriting any manual changes done to this PR._ - Updated the pull request template
1 parent 039d225 commit 69ba74d

File tree

1 file changed

+22
-17
lines changed

1 file changed

+22
-17
lines changed

.github/pull_request_template.md

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
[Reviewers guide](https://www.notion.so/lightbase/Pull-request-PR-reviews-Frontend-66f65f2fc91948a79d8f53a138e6f422)
1+
**Description**
22

33
**Checklist**
44

5-
Please check the following items before submitting the PR. Add relevant explanations for the below points
6-
under the description.
5+
Please check the following items before submitting the PR. Add relevant explanations for the below points in
6+
the description.
77

88
- [ ] The PR title is in line with the following examples:
99
- `chore(ci): add speedups to lint job`
1010
- `fix(user): always show the email in the profile drop down`
1111
- `feat(tags): add SVG symbols to the tag cards`
12-
- [ ] The PR is implemented according to the Acceptance Criteria. Include a link to the ticket `[XYZ-123]` in
13-
the description.
12+
- [ ] The PR is implemented according to the Acceptance Criteria. Include a link to Jira or Sentry in the
13+
description.
1414
- [ ] The PR includes correct use of semantic HTML, aria attributes, etc. See
1515
[Notion](https://www.notion.so/lightbase/Hulpmiddelen-9e06d0c83147455389843e4a7634f022) for tools that
1616
can help you with this.
@@ -27,16 +27,21 @@ under the description.
2727
[technical debt](https://www.notion.so/Technical-debt-refactoring-eabbdee2b66945d7b55517f92cca20bb) is
2828
marked with a TODO comment.
2929
- Obsolete comments are removed.
30-
- [ ] The PR does not add a new dependency. Follow
31-
[this document](https://www.notion.so/lightbase/Introducing-dependencies-ac169cfeafb44782bded308810237737)
32-
and add the link to in the description.
33-
- [ ] The PR does not contain changes to the design system.
34-
- [ ] The PR does not add 'exclusions' on the design system.
35-
- [ ] The PR reuses existing components.
36-
- [ ] The PR does not introduce new base components.
37-
- [ ] The PR uses translations for all necessary strings.
38-
- [ ] The PR does not include unrelated changes.
39-
- [ ] The PR does not include `// @ts-expect-error` / `// eslint-disable` comments.
40-
- [ ] The PR does not mix dependency updates and refactoring with features and fixes.
4130

42-
**Description**
31+
<!-- Other information and points to manually check and if necessary, elaborate on in the description
32+
33+
Jira's links are automatically expanded. So you can write `[JIRA-123]`, which a Jira bot will automatically resolve into a valid url after you have updated a PR comment or description.
34+
Sentry links can be easily copied from the Sentry Issue page by clicking the 'chevron-down' icon -> 'Copy markdown link'.
35+
36+
- The PR does not add a new dependency. Follow [this document](https://www.notion.so/lightbase/Introducing-dependencies-ac169cfeafb44782bded308810237737) and add the link to in the description.
37+
- The PR does not contain changes to the design system.
38+
- The PR does not add 'exclusions' on the design system.
39+
- The PR reuses existing components.
40+
- The PR does not introduce new base components.
41+
- The PR uses translations for all necessary strings.
42+
- The PR does not include unrelated changes.
43+
- The PR does not include `// @ts-expect-error` / `// eslint-disable` comments.
44+
- The PR does not mix dependency updates and refactoring with features and fixes.
45+
-->
46+
47+
[Reviewers guide](https://www.notion.so/lightbase/Pull-request-PR-reviews-Frontend-66f65f2fc91948a79d8f53a138e6f422)

0 commit comments

Comments
 (0)