fix(@clayui/modal): render children only when modal is visible

matuzalemsteles · matuzalemsteles · commit 33083e1b5c1a · 2019-08-28T11:56:54.000-03:00
Prevent breaking components that are trying to get some information from the DOM when they are rendered inside Modal.
diff --git a/packages/clay-modal/src/Modal.tsx b/packages/clay-modal/src/Modal.tsx
@@ -84,7 +84,7 @@ const ClayModal: FunctionComponent<IProps> & {
 									status,
 								}}
 							>
-								{children}
+								{observer.mutation && children}
 							</Context.Provider>
 						</div>
 					</div>

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ const ClayModal: FunctionComponent<IProps> & {`
`84`	`84`	`status,`
`85`	`85`	`}}`
`86`	`86`	`>`
`87`		`- {children}`
	`87`	`+ {observer.mutation && children}`
`88`	`88`	`</Context.Provider>`
`89`	`89`	`</div>`
`90`	`90`	`</div>`