Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a color scheme for dark mode #460

Open
ThunderbirdMailDE opened this issue Sep 6, 2024 · 4 comments
Open

Provide a color scheme for dark mode #460

ThunderbirdMailDE opened this issue Sep 6, 2024 · 4 comments
Milestone

Comments

@ThunderbirdMailDE
Copy link

It would be nice to have a color scheme for dark mode. The main issue is the light background color in this button:

image

A simple solution could be the use of rgba colors for the elemnts background and set alpha for this element to 50 % in dark mode.

@ThunderbirdMailDE
Copy link
Author

ThunderbirdMailDE commented Sep 6, 2024

rgba with alpha set to 0.5:

image

If the alpha 0.5 would be also in light mode:

image

But it's your decission, which colors you would use here.

@ThunderbirdMailDE
Copy link
Author

A possible, working color scheme working for both dark and light mode could be:

image

@lieser
Copy link
Owner

lieser commented Sep 10, 2024

I'm certainly not against changing the defaults colors to something that work good in both the light and dark mode.

Thanks for also providing possible new defaults. First impression is good but I will still take a closer look at it before changing them in the next release.

If someone else wants to try them out the new proposed defaults for easy copy paste:

  • valid: rgba(0,255,0,0.5) - old value: #00FF00
  • valid with warning: rgba(255,150,0,0.5) - old value: orange
  • invalid: rgba(255,0,0,0.5) - old value: red

@lieser lieser added this to the 5.5.0 milestone Sep 10, 2024
@ThunderbirdMailDE
Copy link
Author

The transparency 0.5 could be a problem when hovering the button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants