Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve invalid email message #435

Open
monperrus opened this issue Feb 20, 2024 · 4 comments
Open

improve invalid email message #435

monperrus opened this issue Feb 20, 2024 · 4 comments

Comments

@monperrus
Copy link

Hi!

Today, when an email is invalid it says:

Invalid (E-Mail was modified)

The piece of information which is missing is the signing domain.

Here is a proposal for a better message:

Invalid (E-Mail signed by foo.com was modified)

Thanks!

@lieser
Copy link
Owner

lieser commented Mar 3, 2024

Note that this is an information that should be already become more visible when #160 will get implemented.

But I will also consider extending the message in one of the future releases.

@monperrus
Copy link
Author

monperrus commented Mar 4, 2024 via email

@timcoote
Copy link

Is this possible? The verification compares encrypted hashes, but all you know is that one of several headers, or the body has changed (since body hash is embedded in the signature).

@lieser
Copy link
Owner

lieser commented Apr 28, 2024

Is this possible? The verification compares encrypted hashes, but all you know is that one of several headers, or the body has changed (since body hash is embedded in the signature).

You are correct that it is not possible to reliably get any detailed information about why a DKIM signature failed. You only get that it failed.
Only if you assume that where was no malicious manipulation of the body hash (and the DKIM key was unchanged), you can at least distinguish between the body or the signed headers having changed.
#420 Is about proving that information.

This issue is however not about proving more information why a DKIM signature failed. But only to make it visible from which signing domain the failed DKIM signature claims to be from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants