Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon not shown for local PayPal domains (paypal.de, etc.) #334

Closed
tbertels opened this issue Sep 7, 2022 · 2 comments
Closed

Favicon not shown for local PayPal domains (paypal.de, etc.) #334

tbertels opened this issue Sep 7, 2022 · 2 comments
Assignees
Milestone

Comments

@tbertels
Copy link

tbertels commented Sep 7, 2022

PayPal uses many country code TLDs (ccTLD):
See https://www.xolphin.com/sslcheck/paypal.de fo the full list

DKIM Verifier could show the PayPal favicon for them as well.

The main ones could be added:

paypal.at
paypal.be
paypal.ca
paypal.ch
paypal.cl
paypal.cn
paypal.co
paypal.co.id
paypal.co.il
paypal.co.in
paypal.co.kr
paypal.co.nz
paypal.co.th
paypal.co.uk
paypal.co.za
paypal.com.ar
paypal.com.au
paypal.com.br
paypal.com.hk
paypal.com.mx
paypal.com.my
paypal.com.pe
paypal.com.pt
paypal.com.sa
paypal.com.sg
paypal.com.tr
paypal.com.tw
paypal.com.ve
paypal.de
paypal.dk
paypal.es
paypal.eu
paypal.fi
paypal.fr
paypal.ie
paypal.in
paypal.it
paypal.jp
paypal.lu
paypal.nl
paypal.no
paypal.ph
paypal.pl
paypal.pt
paypal.ru
paypal.se
paypal.vn

@lieser
Copy link
Owner

lieser commented Sep 7, 2022

I did not want to randomly add PayPal also for other top level domains without knowing that PayPal is actually using them.
But thanks for suggesting to use the information included in the certificate PayPal is using for this. I think this is a good idea, will probably add most of them in the next release.

@lieser lieser self-assigned this Sep 7, 2022
@lieser lieser added this to the 5.2.0 milestone Sep 7, 2022
@lieser
Copy link
Owner

lieser commented Oct 16, 2022

Added a lot more local PayPal domains in a904339.

@lieser lieser closed this as completed Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants