Skip to content

Commit

Permalink
ieee1394: fix broken signed char assumption.
Browse files Browse the repository at this point in the history
"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char".  Which only works if "char" is signed - which it
necessarily isn't.

So make that signedness assumption specific.
  • Loading branch information
Linus Torvalds committed Jul 6, 2005
1 parent 184f6eb commit 07bbeaf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/ieee1394/ieee1394_core.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ struct hpsb_packet {

/* These are core internal. */
signed char tlabel;
char ack_code;
char tcode;
signed char ack_code;
unsigned char tcode;

unsigned expect_response:1;
unsigned no_waiter:1;
Expand Down

0 comments on commit 07bbeaf

Please sign in to comment.