Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve share pgn #951

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Improve share pgn #951

merged 2 commits into from
Sep 9, 2024

Conversation

HaonRekcef
Copy link
Contributor

fix #948
This pull request improves the sharing of PGNs:

  • The values of entered text are now saved automatically, so the user doesn't need to submit to save the text.
  • Submitting a field automatically jumps to the next one and selects all text. If the next field is the "Result" field, a choice picker will appear.
  • Tapping on a field automatically selects all the text.
screen-20240831-171730.2.mp4

Remarks:

  • not tested on iOS

@EmmetSchuler
Copy link

Thanks for the quick fix!

@veloce veloce merged commit 815aad3 into lichess-org:main Sep 9, 2024
1 check passed
@HaonRekcef HaonRekcef deleted the fix-share-pgn branch September 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share PGN button doesn't save inputted info
3 participants