Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to request server analysis at the end of the game. #428

Closed
veloce opened this issue Jan 2, 2024 · 0 comments
Closed
Labels
cat: analysis Analysis screen, server analysis, etc. feature New feature
Milestone

Comments

@veloce
Copy link
Contributor

veloce commented Jan 2, 2024

Just like in the website, a "request server analysis" button should be added.

It should appear at the end of the game in the popup showing the result, on top of the other buttons (rematch, etc).

It should also be possible to request it from the game analysis page. Right now we only show the analysis summary button if the analysis is already available:
Capture d’écran 2024-01-02 à 17 31 42

Instead this button should always be there if the analysis is loaded from a user game (GameFullId available). And instead of the graph and analysis summary, a "request analysis" button should be displayed if the analysis is not available yet.

Requesting a new analysis for a game is done with this endpoint:

POST /<gameFullId>/request-analysis

One should connect to the game socket to follow the game analysis progress and notify user when it is done (enabling highlight in the bottom bar button should be enough).

@veloce veloce added feature New feature cat: analysis Analysis screen, server analysis, etc. labels Jan 2, 2024
@veloce veloce modified the milestones: Launch, Beta 2 Jan 3, 2024
@veloce veloce closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: analysis Analysis screen, server analysis, etc. feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant