-
Notifications
You must be signed in to change notification settings - Fork 522
Allow "engine debugging" to be enabled. #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow "engine debugging" to be enabled. #1152
Conversation
|
Good idea. Just fix the errors in the tests. Namely, the |
|
@MarkZH hi, I made the change. Could not find any other class that Stockfish inherits from. But pytest with the latest fix runs fine and it hangs without the fix so my guess is that it is now good? |
config.yml.default
Outdated
| engine: # Engine settings. | ||
| dir: "./engines/" # Directory containing the engine. This can be an absolute path or one relative to lichess-bot/. | ||
| name: "engine_name" # Binary name of the engine to use. | ||
| debug: False # Should all commands between Lichess & bot be logged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really an accurate description. Setting debug: True prints messages about starting and stopping the engine executable. Showing UCI/Xboard communication is controlled by the -v option on the command line.
|
I forgot to mention, please add documentation to the config wiki page: |
Done! |
|
Can you fix the mypy errors? |
Type of pull request:
Description:
This change allows a developer to enable UCI/XBoard protocol debugging to be enabled. This helps debugging communication problems between lichess-bot and certain chess engines.
Related Issues:
[Reference any related issues that this pull request addresses or closes. Use the syntax
Closes #issue_numberto automatically close the linked issue upon merging.]Checklist:
Screenshots/logs (if applicable):