add hid_version/hid_version_str API #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Youw
commented
Sep 27, 2020
Youw
commented
- API functions to get runtime version of the library;
- macros to get static/compile-time version of the library;
- VERSION file;
- API functions to get runtime version of the library; - macros to get static/compile-time version of the library; - VERSION file;
z3ntu
reviewed
Sep 28, 2020
Youw
commented
Sep 28, 2020
vitalys
reviewed
Sep 29, 2020
| @@ -1,7 +1,7 @@ | |||
| Pod::Spec.new do |spec| | |||
|
|
|||
| spec.name = "hidapi" | |||
| spec.version = "0.9.0" | |||
| spec.version = "<fill me up from VERSION file, before submit>" | |||
There was a problem hiding this comment.
Looks like it's possible to read version from VERSION file
spec.version = File.read('../VERSION')
I'm going to try this during publishing 0.10.0, and if it will work, I create a PR
Youw
added a commit
that referenced
this pull request
Nov 23, 2020
- API functions to get runtime version of the library; - macros to get static/compile-time version of the library; - VERSION file;
SomberNight
added a commit
to SomberNight/cython-hidapi
that referenced
this pull request
Aug 22, 2022
`hid_version_str` was added to the underlying C library in 0.10.0, in libusb/hidapi#192 Note that the method added here returns the version of the C library, which is different from the version of cython-hidapi, i.e. the `hid` python package. It would be good to also make the latter available at runtime somehow.
prusnak
pushed a commit
to trezor/cython-hidapi
that referenced
this pull request
Aug 22, 2022
`hid_version_str` was added to the underlying C library in 0.10.0, in libusb/hidapi#192 Note that the method added here returns the version of the C library, which is different from the version of cython-hidapi, i.e. the `hid` python package. It would be good to also make the latter available at runtime somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.