Skip to content

Better interoperability between MSVC and mingw-w64, 3 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

nijtmans
Copy link
Collaborator

Another try, sucessor of the -2 branch. I don't know how to integrate generate_def.sh with helper.pl.

The .def-file doesn't include deprecated symbols, that's on purpose: I don't really care about those ;-)

@nijtmans
Copy link
Collaborator Author

B.T.W: the current makefile.mingw in develop is wrong: it contains too many lines with duplicate .o-files. Fixed in this branch!

@minad minad self-requested a review May 28, 2019 12:43
@nijtmans nijtmans requested a review from sjaeckel May 28, 2019 13:12
Copy link
Member

@minad minad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally approve but I think we have to fix the dependency system to handle bn_conversion.c and bn_deprecated.c. Furthermore the def generation should be part of helper.pl later.

@minad minad self-requested a review May 28, 2019 13:23
@minad
Copy link
Member

minad commented May 28, 2019

...we have to fix the dependency system...

@czurnieden and I talked about improving the configuration system before. Maybe I find time to work on this at some point and propose a PR.

@nijtmans
Copy link
Collaborator Author

I generally approve but I think we have to fix the dependency system to handle bn_conversion.c and bn_deprecated.c. Furthermore the def generation should be part of helper.pl later.

Agreed! Actually, I don't care about bn_deprecated.c, but the bn_conversion.c symbols - indeed - must be handled separately. I don't know how to do that better, without actually deriving the symbols from a built library. Yes, it should be part of helper.pl later!

@minad
Copy link
Member

minad commented May 28, 2019

I don't know how to do that better, without actually deriving the symbols from a built library.

Either we split bn_deprecated/bn_conversion again per function or we improve the regex "parser" in helper.pl which generates tommath_class etc. The def file should also be generated from that data then.

@nijtmans
Copy link
Collaborator Author

I think this one is ready to be merged to develop. Further improvements/cleanups in generating the .def-file can be done in a separate PR.

@minad
Copy link
Member

minad commented May 29, 2019

Agree, there is already something going on in #301

@minad
Copy link
Member

minad commented Jun 4, 2019

@sjaeckel I think this is ready too.

@nijtmans
Copy link
Collaborator Author

nijtmans commented Jun 6, 2019

@sjaeckel ping ???

@sjaeckel sjaeckel force-pushed the interop-mingw-w64-3 branch from 522328f to 28dc77a Compare June 6, 2019 08:38
@sjaeckel sjaeckel merged commit 380d03b into develop Jun 6, 2019
@sjaeckel sjaeckel deleted the interop-mingw-w64-3 branch June 6, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants