Skip to content

fix invalid OBJECTS=... definition in makefile.msvc #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

karel-m
Copy link
Member

@karel-m karel-m commented May 25, 2019

Related to #224

Fixes fatal error U1034: syntax error : separator missing mentioned in the following comment:

I tried quickly using appveyor and at least I managed to start "nmake -f makefile.msvc all" but then I got a parse error (seperator : missing or sth)?! Can some windows user please try this?

@karel-m karel-m force-pushed the fix-makefile-msvc branch from 746af5d to 3b79eac Compare May 25, 2019 21:09
@karel-m karel-m force-pushed the fix-makefile-msvc branch from 3b79eac to 9578d67 Compare May 25, 2019 21:11
@karel-m karel-m changed the title missing backclash in makefile.msvc fix invalid OBJECTS=... definition in makefile.msvc May 25, 2019
@minad
Copy link
Member

minad commented May 26, 2019

Thank you @karel-m! I will try this! Could you please also quickly check #262 since I have no possibility to test those various compilers?

@minad
Copy link
Member

minad commented May 26, 2019

I was looking for a missing backslash but I didn't see it 🙈

@minad
Copy link
Member

minad commented May 26, 2019

superseded by #297. #297 is based on this PR and includes @karel-m's commit.

@minad minad closed this May 26, 2019
@minad minad deleted the fix-makefile-msvc branch November 14, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants