Skip to content

deprecate mp_prime_is_divisible and ltm_prime_tab #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2019
Merged

deprecate mp_prime_is_divisible and ltm_prime_tab #288

merged 1 commit into from
May 24, 2019

Conversation

minad
Copy link
Member

@minad minad commented May 22, 2019

  • it is an implementation detail used for prime testing
  • there is upcoming work by @czurnieden regarding a generalised prime sieve
  • furthermore remove jacobi test (replaced by kronecker)

@minad minad requested a review from czurnieden May 22, 2019 13:43
@minad minad mentioned this pull request May 22, 2019
Closed
@minad
Copy link
Member Author

minad commented May 22, 2019

@czurnieden I know you argued before that we will probably keep this function just as a quick early test. But I think it makes sense to make it internal and provide something better in the public API.

@minad minad force-pushed the deprecate-is-divisible branch from 6b5c4ab to deea98b Compare May 22, 2019 14:06
@czurnieden
Copy link
Contributor

there is upcoming work by @czurnieden regarding a generalised prime sieve

Still lingering in limbo.
It needs a rebase now and probably some formal changes to reflect the changed API but is otherwise fully functional.

@czurnieden I know you argued before that we will probably keep this function just as a quick early test. But I think it makes sense to make it internal and provide something better in the public API.

No problem.

@minad
Copy link
Member Author

minad commented May 22, 2019

Still lingering in limbo. It needs a rebase now and probably some formal changes to reflect the changed API but is otherwise fully functional.

Sure that's ok and there is no hurry. I just want to take a tiny step towards it and I am ticking of some things in #243.

@minad minad mentioned this pull request May 23, 2019
Merged
@minad minad force-pushed the deprecate-is-divisible branch from deea98b to 5a9e225 Compare May 23, 2019 22:16
@minad minad mentioned this pull request May 24, 2019
Merged
@minad minad force-pushed the deprecate-is-divisible branch from 5a9e225 to aca949f Compare May 24, 2019 09:46
@minad
Copy link
Member Author

minad commented May 24, 2019

rebased

@sjaeckel
Copy link
Member

can you please fix the conflicts

@minad minad force-pushed the deprecate-is-divisible branch from aca949f to 88e8821 Compare May 24, 2019 10:02
@minad
Copy link
Member Author

minad commented May 24, 2019

done

@minad @sjaeckel
deprecate mp_prime_is_divisible and ltm_prime_tab
bcec605 
* it is an implementation detail used for prime testing
* there is upcoming work by @czurnieden regarding a generalised prime sieve
* furthermore remove jacobi test (replaced by kronecker)
@sjaeckel sjaeckel force-pushed the deprecate-is-divisible branch from 88e8821 to bcec605 Compare May 24, 2019 10:31
@sjaeckel sjaeckel merged commit 8e1704d into develop May 24, 2019
@sjaeckel sjaeckel deleted the deprecate-is-divisible branch May 24, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaeckel sjaeckel sjaeckel approved these changes

@czurnieden czurnieden czurnieden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minad @czurnieden @sjaeckel