Skip to content

Get rid of BN prefix #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Get rid of BN prefix #284

merged 2 commits into from
Oct 20, 2019

Conversation

minad
Copy link
Member

@minad minad commented May 21, 2019

Another trivial one 😁

In the beginning it seemed there were three different prefixes, MP, BN and LTM. Fortunately it seems we now settled on mp and s_mp. This renames all the things to comply with that.
Furthermore I find the current bn_s_mp_ prefix a bit hard on the eye.

This is done similarly to #172 via a move script.

Not to be merged now, don't worry about all your open PRs!

@minad minad force-pushed the move-files branch 6 times, most recently from b375520 to 11739a1 Compare May 27, 2019 18:43
@minad minad force-pushed the move-files branch 2 times, most recently from 0ac108d to d2c5e30 Compare June 12, 2019 10:10
@minad minad force-pushed the move-files branch 2 times, most recently from fd4751a to 6cc5295 Compare July 24, 2019 09:18
@sjaeckel sjaeckel added this to the v2.0.0 milestone Sep 2, 2019
@minad
Copy link
Member Author

minad commented Sep 2, 2019

@sjaeckel Any reason to delay this PR for 2.0 (in general, what are you plans about a new release, removing deprecations etc)? This PR shouldn't have any user facing implications (no abi/api changes).

@sjaeckel
Copy link
Member

sjaeckel commented Sep 2, 2019

@sjaeckel Any reason to delay this PR for 2.0 (in general, what are you plans about a new release, removing deprecations etc)? This PR shouldn't have any user facing implications (no abi/api changes).

it changes the user facing defines in tommath_class.h that are used to trim the library, so I'd prefer to push this to 2.0

@minad
Copy link
Member Author

minad commented Sep 3, 2019

tommath_class.h is not included in tommath.h anymore.

@sjaeckel
Copy link
Member

sjaeckel commented Sep 3, 2019

tommath_class.h is not included in tommath.h anymore.

that's true, but I still count this way of tweaking/configuring ltm as a feature that I don't want to break.

@minad minad force-pushed the move-files branch 3 times, most recently from ed27ff8 to dcf5738 Compare September 9, 2019 17:19
@minad minad force-pushed the move-files branch 2 times, most recently from 4e95c38 to 2b8d947 Compare September 23, 2019 19:34
@minad minad force-pushed the move-files branch 2 times, most recently from 780d866 to 64b1148 Compare October 8, 2019 19:18
@minad minad added the finished label Oct 8, 2019
@minad minad force-pushed the move-files branch 4 times, most recently from 1697fd7 to 1dd9eb5 Compare October 16, 2019 12:47
minad and others added 2 commits October 19, 2019 16:24
* git blame <renamed-file> is not affected
* git log --follow <renamed-file> can be used to show log across renames
@minad
Copy link
Member Author

minad commented Oct 20, 2019

@sjaeckel could you please merge this soon since otherwise we have to chaotically rebase everything very often. @czurnieden is already starting with new stuff.

Also #387, #388, #390 are ready for merge.

@sjaeckel sjaeckel merged commit 2c82730 into develop Oct 20, 2019
@sjaeckel sjaeckel deleted the move-files branch October 20, 2019 10:35
@sjaeckel
Copy link
Member

I wanted to merge yesterday already but had to leave, sorry

@sjaeckel sjaeckel removed the finished label Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants