introduce MP_PRIVATE to hide symbols #275
Merged
+55
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating a Windows def-file is done in #216, still needs a rebase. |
minad
force-pushed
the
hidden-symbols
branch
2 times, most recently
from
7a7494e to
bd6999c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative would be to compile with hidden symbols by default and make functions public via an visibility=default attribute. This would be consistent with Windows and declspec(dllexport) for the public symbols. However then we would pollute tommath.h prototypes with MP_PUBLIC attributes. Right now we need a .def file to specify exported symbols on Windows.