Better interoperability between MSVC and mingw-w64, 2 #216
Conversation
|
how's this def file created? |
Manually, just by building first and then using nm to make a list of the exported symbols. It just contains a list of exported symbols in alphabetical order (not really necessary, actually). Should be generated by a script, but I'm not confident in perl doing that. |
no need to do it in perl, I'd use the same tools as @minad did in I think this script needs to do more in the future, but what you described is enough for now. In the future (2.0.0) it should build the library, then check vs. what is in |
|
can you please rebase on top of develop and squash all those commits? |
nijtmans
force-pushed
the
interop-mingw-w64-2
branch
from
aefcf64 to
fbc0829
Compare
Done @sjaeckel |
|
Thx! @karel-m can you please have a look at these changes, fine by you as well? |
@nijtmans I had expected that something like this might work. However you mentioned that tcl accesses the mp_int structs. How will that work? |
|
Ah, and why do you need a def file? Just asking, I don't know what they are for. Some kind of additional infos for the linker? |
Well, it works: See here. As long as Tcl is compiled with the same MP-mode as the libtommath library, it works. (There were a few fixes needed in the Tcl source-code, but those are done now) |
A def-file is needed for MSVC-builds, the import-libraries can be generated from it. |
Add handling of MP_ITER error-code to mp_error_to_string()
Rename internals
as of @czurnieden "there's always leftovers" and he's right that's a leftover of #127
fix includes
Msvc fixes (appveyor works!)
fix appveyor.yml
minor improvements&fixes
Simplify scripts
These functions were introduced to give some timing guarantees. However the guarantees are too weak to be useful. The functions seem to be unused essentially by downstream users.
deprecate mp_n_root_ex and mp_expt_d_ex
…what symbols are there. Re-generation script should deliver the same file.
Re-generate tommath.def, by actually building with mingw-w64 and see what symbols are there. Re-generation script should deliver the same file.
…ommath into interop-mingw-w64-2
|
Well, I tried to rebase, but somehow that failed horribily |
hmm I tried the rebase of the old HEAD @ fbc0829 and there was a minor merge conflict, but otherwise it went smoothly now that we have |
I've pushed the rebased branch to rebased/interop-mingw-w64-2 |
|
Closing in favour of #300 |
Here is another attempt, which succeeded to produce a single "libtommath.dll" (actually 2: win32 and win64) which is usable for both MSVC and mingw-w64. The dll can be built normally, only an addtional compiler option prevents that it depends on a mingw-w64 specific dll.
I built Tcl with MSVC (both win32 and win64) and with mingw-w64 (also win32 and win64), but replacing the built-in libtommath with "libtommath.dll". It worked. The MSVC import library "tommath.lib" must be generated using a def-file (tommath.def), which is also committed. Ideally, this .def-file should be automatically generated (as is done with the makefiles), but I'm not confident enough in perl to implement that.
Advantage of this approach: MSVC-built application can benefit from DIGIT_BITS=60, even though the compiler cannot build the dll. But it can import the mingw-w64-generated dll, and fully interoperate with it.