Skip to content

Commit 4132882

Browse files
minadminad
committed
deprecate mp_jacobi
1 parent 6494ca3 commit 4132882

14 files changed

+215
-233
lines changed

‎bn_deprecated.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,22 @@
66

77
/* SPDX-License-Identifier: Unlicense */
88
#include <tommath_private.h>
9+
#ifdef BN_MP_JACOBI_C
10+
mp_err s_mp_jacobi(const mp_int *a, const mp_int *n, int *c)
11+
{
12+
if (a->sign == MP_NEG) {
13+
return MP_VAL;
14+
}
15+
if (mp_cmp_d(n, 0uL) != MP_GT) {
16+
return MP_VAL;
17+
}
18+
return mp_kronecker(a, n, c);
19+
}
20+
mp_err mp_jacobi(const mp_int *a, const mp_int *n, int *c)
21+
{
22+
return s_mp_jacobi(a, n, c);
23+
}
24+
#endif
925
#ifdef BN_MP_PRIME_RANDOM_EX_C
1026
mp_err mp_prime_random_ex(mp_int *a, int t, int size, int flags, private_mp_prime_callback cb, void *dat)
1127
{

‎bn_mp_jacobi.c

Lines changed: 0 additions & 23 deletions
This file was deleted.

‎bn_mp_sqrtmod_prime.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ mp_err mp_sqrtmod_prime(const mp_int *n, const mp_int *prime, mp_int *ret)
2222
return MP_OKAY;
2323
}
2424
if (mp_cmp_d(prime, 2uL) == MP_EQ) return MP_VAL; /* prime must be odd */
25-
if ((res = mp_jacobi(n, prime, &legendre)) != MP_OKAY) return res;
25+
if ((res = mp_kronecker(n, prime, &legendre)) != MP_OKAY) return res;
2626
if (legendre == -1) return MP_VAL; /* quadratic non-residue mod prime */
2727

2828
if ((res = mp_init_multi(&t1, &C, &Q, &S, &Z, &M, &T, &R, &two, NULL)) != MP_OKAY) {
@@ -62,7 +62,7 @@ mp_err mp_sqrtmod_prime(const mp_int *n, const mp_int *prime, mp_int *ret)
6262
mp_set_int(&Z, 2uL);
6363
/* Z = 2 */
6464
while (1) {
65-
if ((res = mp_jacobi(&Z, prime, &legendre)) != MP_OKAY) goto cleanup;
65+
if ((res = mp_kronecker(&Z, prime, &legendre)) != MP_OKAY) goto cleanup;
6666
if (legendre == -1) break;
6767
if ((res = mp_add_d(&Z, 1uL, &Z)) != MP_OKAY) goto cleanup;
6868
/* Z = Z + 1 */

‎callgraph.txt

Lines changed: 121 additions & 127 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,75 @@ BN_CUTOFFS_C
22

33

44
BN_DEPRECATED_C
5+
+--->BN_MP_CMP_D_C
6+
+--->BN_MP_KRONECKER_C
7+
| +--->BN_MP_INIT_COPY_C
8+
| | +--->BN_MP_INIT_SIZE_C
9+
| | +--->BN_MP_COPY_C
10+
| | | +--->BN_MP_GROW_C
11+
| | +--->BN_MP_CLEAR_C
12+
| +--->BN_MP_CNT_LSB_C
13+
| +--->BN_MP_DIV_2D_C
14+
| | +--->BN_MP_COPY_C
15+
| | | +--->BN_MP_GROW_C
16+
| | +--->BN_MP_ZERO_C
17+
| | +--->BN_MP_MOD_2D_C
18+
| | | +--->BN_MP_CLAMP_C
19+
| | +--->BN_MP_RSHD_C
20+
| | +--->BN_MP_CLAMP_C
21+
| +--->BN_MP_COPY_C
22+
| | +--->BN_MP_GROW_C
23+
| +--->BN_MP_MOD_C
24+
| | +--->BN_MP_INIT_SIZE_C
25+
| | +--->BN_MP_DIV_C
26+
| | | +--->BN_MP_CMP_MAG_C
27+
| | | +--->BN_MP_ZERO_C
28+
| | | +--->BN_MP_INIT_MULTI_C
29+
| | | | +--->BN_MP_CLEAR_C
30+
| | | +--->BN_MP_SET_C
31+
| | | +--->BN_MP_COUNT_BITS_C
32+
| | | +--->BN_MP_ABS_C
33+
| | | +--->BN_MP_MUL_2D_C
34+
| | | | +--->BN_MP_GROW_C
35+
| | | | +--->BN_MP_LSHD_C
36+
| | | | +--->BN_MP_CLAMP_C
37+
| | | +--->BN_MP_CMP_C
38+
| | | +--->BN_MP_SUB_C
39+
| | | | +--->BN_S_MP_ADD_C
40+
| | | | | +--->BN_MP_GROW_C
41+
| | | | | +--->BN_MP_CLAMP_C
42+
| | | | +--->BN_S_MP_SUB_C
43+
| | | | | +--->BN_MP_GROW_C
44+
| | | | | +--->BN_MP_CLAMP_C
45+
| | | +--->BN_MP_ADD_C
46+
| | | | +--->BN_S_MP_ADD_C
47+
| | | | | +--->BN_MP_GROW_C
48+
| | | | | +--->BN_MP_CLAMP_C
49+
| | | | +--->BN_S_MP_SUB_C
50+
| | | | | +--->BN_MP_GROW_C
51+
| | | | | +--->BN_MP_CLAMP_C
52+
| | | +--->BN_MP_EXCH_C
53+
| | | +--->BN_MP_CLEAR_MULTI_C
54+
| | | | +--->BN_MP_CLEAR_C
55+
| | | +--->BN_MP_LSHD_C
56+
| | | | +--->BN_MP_GROW_C
57+
| | | +--->BN_MP_RSHD_C
58+
| | | +--->BN_MP_MUL_D_C
59+
| | | | +--->BN_MP_GROW_C
60+
| | | | +--->BN_MP_CLAMP_C
61+
| | | +--->BN_MP_CLAMP_C
62+
| | | +--->BN_MP_CLEAR_C
63+
| | +--->BN_MP_CLEAR_C
64+
| | +--->BN_MP_EXCH_C
65+
| | +--->BN_MP_ADD_C
66+
| | | +--->BN_S_MP_ADD_C
67+
| | | | +--->BN_MP_GROW_C
68+
| | | | +--->BN_MP_CLAMP_C
69+
| | | +--->BN_MP_CMP_MAG_C
70+
| | | +--->BN_S_MP_SUB_C
71+
| | | | +--->BN_MP_GROW_C
72+
| | | | +--->BN_MP_CLAMP_C
73+
| +--->BN_MP_CLEAR_C
574
+--->BN_S_MP_INVMOD_FAST_C
675
| +--->BN_MP_INIT_MULTI_C
776
| | +--->BN_MP_INIT_C
@@ -79,7 +148,6 @@ BN_DEPRECATED_C
79148
| | | +--->BN_MP_CLAMP_C
80149
| +--->BN_MP_CMP_C
81150
| | +--->BN_MP_CMP_MAG_C
82-
| +--->BN_MP_CMP_D_C
83151
| +--->BN_MP_ADD_C
84152
| | +--->BN_S_MP_ADD_C
85153
| | | +--->BN_MP_GROW_C
@@ -586,7 +654,6 @@ BN_DEPRECATED_C
586654
| | | +--->BN_MP_CLAMP_C
587655
| +--->BN_MP_CMP_C
588656
| | +--->BN_MP_CMP_MAG_C
589-
| +--->BN_MP_CMP_D_C
590657
| +--->BN_MP_CMP_MAG_C
591658
| +--->BN_MP_EXCH_C
592659
| +--->BN_MP_CLEAR_MULTI_C
@@ -3188,78 +3255,6 @@ BN_MP_IS_SQUARE_C
31883255
+--->BN_MP_CLEAR_C
31893256

31903257

3191-
BN_MP_JACOBI_C
3192-
+--->BN_MP_CMP_D_C
3193-
+--->BN_MP_KRONECKER_C
3194-
| +--->BN_MP_INIT_COPY_C
3195-
| | +--->BN_MP_INIT_SIZE_C
3196-
| | +--->BN_MP_COPY_C
3197-
| | | +--->BN_MP_GROW_C
3198-
| | +--->BN_MP_CLEAR_C
3199-
| +--->BN_MP_CNT_LSB_C
3200-
| +--->BN_MP_DIV_2D_C
3201-
| | +--->BN_MP_COPY_C
3202-
| | | +--->BN_MP_GROW_C
3203-
| | +--->BN_MP_ZERO_C
3204-
| | +--->BN_MP_MOD_2D_C
3205-
| | | +--->BN_MP_CLAMP_C
3206-
| | +--->BN_MP_RSHD_C
3207-
| | +--->BN_MP_CLAMP_C
3208-
| +--->BN_MP_COPY_C
3209-
| | +--->BN_MP_GROW_C
3210-
| +--->BN_MP_MOD_C
3211-
| | +--->BN_MP_INIT_SIZE_C
3212-
| | +--->BN_MP_DIV_C
3213-
| | | +--->BN_MP_CMP_MAG_C
3214-
| | | +--->BN_MP_ZERO_C
3215-
| | | +--->BN_MP_INIT_MULTI_C
3216-
| | | | +--->BN_MP_CLEAR_C
3217-
| | | +--->BN_MP_SET_C
3218-
| | | +--->BN_MP_COUNT_BITS_C
3219-
| | | +--->BN_MP_ABS_C
3220-
| | | +--->BN_MP_MUL_2D_C
3221-
| | | | +--->BN_MP_GROW_C
3222-
| | | | +--->BN_MP_LSHD_C
3223-
| | | | +--->BN_MP_CLAMP_C
3224-
| | | +--->BN_MP_CMP_C
3225-
| | | +--->BN_MP_SUB_C
3226-
| | | | +--->BN_S_MP_ADD_C
3227-
| | | | | +--->BN_MP_GROW_C
3228-
| | | | | +--->BN_MP_CLAMP_C
3229-
| | | | +--->BN_S_MP_SUB_C
3230-
| | | | | +--->BN_MP_GROW_C
3231-
| | | | | +--->BN_MP_CLAMP_C
3232-
| | | +--->BN_MP_ADD_C
3233-
| | | | +--->BN_S_MP_ADD_C
3234-
| | | | | +--->BN_MP_GROW_C
3235-
| | | | | +--->BN_MP_CLAMP_C
3236-
| | | | +--->BN_S_MP_SUB_C
3237-
| | | | | +--->BN_MP_GROW_C
3238-
| | | | | +--->BN_MP_CLAMP_C
3239-
| | | +--->BN_MP_EXCH_C
3240-
| | | +--->BN_MP_CLEAR_MULTI_C
3241-
| | | | +--->BN_MP_CLEAR_C
3242-
| | | +--->BN_MP_LSHD_C
3243-
| | | | +--->BN_MP_GROW_C
3244-
| | | +--->BN_MP_RSHD_C
3245-
| | | +--->BN_MP_MUL_D_C
3246-
| | | | +--->BN_MP_GROW_C
3247-
| | | | +--->BN_MP_CLAMP_C
3248-
| | | +--->BN_MP_CLAMP_C
3249-
| | | +--->BN_MP_CLEAR_C
3250-
| | +--->BN_MP_CLEAR_C
3251-
| | +--->BN_MP_EXCH_C
3252-
| | +--->BN_MP_ADD_C
3253-
| | | +--->BN_S_MP_ADD_C
3254-
| | | | +--->BN_MP_GROW_C
3255-
| | | | +--->BN_MP_CLAMP_C
3256-
| | | +--->BN_MP_CMP_MAG_C
3257-
| | | +--->BN_S_MP_SUB_C
3258-
| | | | +--->BN_MP_GROW_C
3259-
| | | | +--->BN_MP_CLAMP_C
3260-
| +--->BN_MP_CLEAR_C
3261-
3262-
32633258
BN_MP_KRONECKER_C
32643259
+--->BN_MP_INIT_COPY_C
32653260
| +--->BN_MP_INIT_SIZE_C
@@ -12737,73 +12732,72 @@ BN_MP_SQRMOD_C
1273712732
BN_MP_SQRTMOD_PRIME_C
1273812733
+--->BN_MP_CMP_D_C
1273912734
+--->BN_MP_ZERO_C
12740-
+--->BN_MP_JACOBI_C
12741-
| +--->BN_MP_KRONECKER_C
12742-
| | +--->BN_MP_INIT_COPY_C
12743-
| | | +--->BN_MP_INIT_SIZE_C
12744-
| | | +--->BN_MP_COPY_C
12745-
| | | | +--->BN_MP_GROW_C
12746-
| | | +--->BN_MP_CLEAR_C
12747-
| | +--->BN_MP_CNT_LSB_C
12748-
| | +--->BN_MP_DIV_2D_C
12749-
| | | +--->BN_MP_COPY_C
12750-
| | | | +--->BN_MP_GROW_C
12751-
| | | +--->BN_MP_MOD_2D_C
12752-
| | | | +--->BN_MP_CLAMP_C
12753-
| | | +--->BN_MP_RSHD_C
12754-
| | | +--->BN_MP_CLAMP_C
12735+
+--->BN_MP_KRONECKER_C
12736+
| +--->BN_MP_INIT_COPY_C
12737+
| | +--->BN_MP_INIT_SIZE_C
1275512738
| | +--->BN_MP_COPY_C
1275612739
| | | +--->BN_MP_GROW_C
12757-
| | +--->BN_MP_MOD_C
12758-
| | | +--->BN_MP_INIT_SIZE_C
12759-
| | | +--->BN_MP_DIV_C
12760-
| | | | +--->BN_MP_CMP_MAG_C
12761-
| | | | +--->BN_MP_INIT_MULTI_C
12762-
| | | | | +--->BN_MP_CLEAR_C
12763-
| | | | +--->BN_MP_SET_C
12764-
| | | | +--->BN_MP_COUNT_BITS_C
12765-
| | | | +--->BN_MP_ABS_C
12766-
| | | | +--->BN_MP_MUL_2D_C
12767-
| | | | | +--->BN_MP_GROW_C
12768-
| | | | | +--->BN_MP_LSHD_C
12769-
| | | | | +--->BN_MP_CLAMP_C
12770-
| | | | +--->BN_MP_CMP_C
12771-
| | | | +--->BN_MP_SUB_C
12772-
| | | | | +--->BN_S_MP_ADD_C
12773-
| | | | | | +--->BN_MP_GROW_C
12774-
| | | | | | +--->BN_MP_CLAMP_C
12775-
| | | | | +--->BN_S_MP_SUB_C
12776-
| | | | | | +--->BN_MP_GROW_C
12777-
| | | | | | +--->BN_MP_CLAMP_C
12778-
| | | | +--->BN_MP_ADD_C
12779-
| | | | | +--->BN_S_MP_ADD_C
12780-
| | | | | | +--->BN_MP_GROW_C
12781-
| | | | | | +--->BN_MP_CLAMP_C
12782-
| | | | | +--->BN_S_MP_SUB_C
12783-
| | | | | | +--->BN_MP_GROW_C
12784-
| | | | | | +--->BN_MP_CLAMP_C
12785-
| | | | +--->BN_MP_EXCH_C
12786-
| | | | +--->BN_MP_CLEAR_MULTI_C
12787-
| | | | | +--->BN_MP_CLEAR_C
12740+
| | +--->BN_MP_CLEAR_C
12741+
| +--->BN_MP_CNT_LSB_C
12742+
| +--->BN_MP_DIV_2D_C
12743+
| | +--->BN_MP_COPY_C
12744+
| | | +--->BN_MP_GROW_C
12745+
| | +--->BN_MP_MOD_2D_C
12746+
| | | +--->BN_MP_CLAMP_C
12747+
| | +--->BN_MP_RSHD_C
12748+
| | +--->BN_MP_CLAMP_C
12749+
| +--->BN_MP_COPY_C
12750+
| | +--->BN_MP_GROW_C
12751+
| +--->BN_MP_MOD_C
12752+
| | +--->BN_MP_INIT_SIZE_C
12753+
| | +--->BN_MP_DIV_C
12754+
| | | +--->BN_MP_CMP_MAG_C
12755+
| | | +--->BN_MP_INIT_MULTI_C
12756+
| | | | +--->BN_MP_CLEAR_C
12757+
| | | +--->BN_MP_SET_C
12758+
| | | +--->BN_MP_COUNT_BITS_C
12759+
| | | +--->BN_MP_ABS_C
12760+
| | | +--->BN_MP_MUL_2D_C
12761+
| | | | +--->BN_MP_GROW_C
1278812762
| | | | +--->BN_MP_LSHD_C
12763+
| | | | +--->BN_MP_CLAMP_C
12764+
| | | +--->BN_MP_CMP_C
12765+
| | | +--->BN_MP_SUB_C
12766+
| | | | +--->BN_S_MP_ADD_C
1278912767
| | | | | +--->BN_MP_GROW_C
12790-
| | | | +--->BN_MP_RSHD_C
12791-
| | | | +--->BN_MP_MUL_D_C
12768+
| | | | | +--->BN_MP_CLAMP_C
12769+
| | | | +--->BN_S_MP_SUB_C
1279212770
| | | | | +--->BN_MP_GROW_C
1279312771
| | | | | +--->BN_MP_CLAMP_C
12794-
| | | | +--->BN_MP_CLAMP_C
12795-
| | | | +--->BN_MP_CLEAR_C
12796-
| | | +--->BN_MP_CLEAR_C
12797-
| | | +--->BN_MP_EXCH_C
1279812772
| | | +--->BN_MP_ADD_C
1279912773
| | | | +--->BN_S_MP_ADD_C
1280012774
| | | | | +--->BN_MP_GROW_C
1280112775
| | | | | +--->BN_MP_CLAMP_C
12802-
| | | | +--->BN_MP_CMP_MAG_C
1280312776
| | | | +--->BN_S_MP_SUB_C
1280412777
| | | | | +--->BN_MP_GROW_C
1280512778
| | | | | +--->BN_MP_CLAMP_C
12779+
| | | +--->BN_MP_EXCH_C
12780+
| | | +--->BN_MP_CLEAR_MULTI_C
12781+
| | | | +--->BN_MP_CLEAR_C
12782+
| | | +--->BN_MP_LSHD_C
12783+
| | | | +--->BN_MP_GROW_C
12784+
| | | +--->BN_MP_RSHD_C
12785+
| | | +--->BN_MP_MUL_D_C
12786+
| | | | +--->BN_MP_GROW_C
12787+
| | | | +--->BN_MP_CLAMP_C
12788+
| | | +--->BN_MP_CLAMP_C
12789+
| | | +--->BN_MP_CLEAR_C
1280612790
| | +--->BN_MP_CLEAR_C
12791+
| | +--->BN_MP_EXCH_C
12792+
| | +--->BN_MP_ADD_C
12793+
| | | +--->BN_S_MP_ADD_C
12794+
| | | | +--->BN_MP_GROW_C
12795+
| | | | +--->BN_MP_CLAMP_C
12796+
| | | +--->BN_MP_CMP_MAG_C
12797+
| | | +--->BN_S_MP_SUB_C
12798+
| | | | +--->BN_MP_GROW_C
12799+
| | | | +--->BN_MP_CLAMP_C
12800+
| +--->BN_MP_CLEAR_C
1280712801
+--->BN_MP_INIT_MULTI_C
1280812802
| +--->BN_MP_INIT_C
1280912803
| +--->BN_MP_CLEAR_C

0 commit comments

Comments
 (0)