This repository was archived by the owner on Oct 18, 2023. It is now read-only.
Vacuum before checkpointing #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a transaction that spans multiple xFrames calls, it's ok if our last_valid_frame doesn't match the one that came with xFrames. As long as our last_valid_frame is *not greater* than the one reported, we're good. If it's greater, we're in trouble and we report a bug.
This commit adds an optional VACUUM operation before our periodic checkpoint -- since VACUUM should always be followe by a checkpoint. The are two criteria to qualify for vacuuming: 1. We have at least 32MiB of data 2. There are more free pages in the db than regular ones If that's the case, we keep the db file more than 2x larger than it could be, and that calls for a vacuum. Also, for small databases, we entirely skip vacuuming. Fixes libsql#734
MarinPostma
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an optional VACUUM operation before our
periodic checkpoint -- since VACUUM should always be followe
by a checkpoint.
The are two criteria to qualify for vacuuming:
If that's the case, we keep the db file more than 2x larger
than it could be, and that calls for a vacuum.
Also, for small databases, we entirely skip vacuuming.
Fixes #734