Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Binding params in HTTP queries #13

Closed
MarinPostma opened this issue Jan 9, 2023 · 1 comment
Closed

Binding params in HTTP queries #13

MarinPostma opened this issue Jan 9, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MarinPostma
Copy link
Contributor

It would be interesting to be able to bind parameters in HTTP queries, once #12 lands. I'm not completely sure about the API though.

Currently, there request payload looks like this:

{
    "statements": [/* stmts */],
}

We could for, for example add a params fields to the payload, with variables scoping all the statements in statement, e.g:

{
    "statements": ["select * from users where name = $name"],
    "params": {
        "name": "adhoc",
    }
}

another option could be statement-scoped variables, like so:

{
    "statements": [{ "statement": "select * from users where name = $name", "params": {"name": "adhoc"}}],
}
@MarinPostma MarinPostma added help wanted Extra attention is needed enhancement New feature or request labels Jan 9, 2023
@CodingDoug
Copy link
Contributor

This issue seems closeable @MarinPostma.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants