Fix out of boundary access in src_linear.c
#209
+208
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to repro a bug reported in libsndfile#208
Fix libsndfile#208 about out of bount access in linear resampler. Also migrates to count the sumber of frames instead of the number of samples and remove some redundant member of the private state. Signed-off-by: Lionel Koenig Gélas <lionel.koenig@gmail.com>
lkoenig
changed the title
src_linear.c
Author
|
Is there any reason, why this shouldn't be merged? |
Author
|
None I can see.
…On Sat, 4 Jan 2025, 11:43 JoergAtGithub, ***@***.***> wrote:
Is there any reason, why this shouldn't be merged?
—
Reply to this email directly, view it on GitHub
<#209 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADGWMKF3GBLHXQ554J2UBD2I63NHAVCNFSM6AAAAABUS7S466VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGI2DGMZVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case with different consecutive buffer size and a fix for #208.