Skip to content

Commit 3c29d61

Browse files
committed
PRINCE: Code clean-up
1 parent b3589c7 commit 3c29d61

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+394
-600
lines changed

engines/prince/animation.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,5 +192,3 @@ Graphics::Surface *Animation::getFrame(int frameIndex) {
192192
}
193193

194194
} // End of namespace Prince
195-
196-
/* vim: set tabstop=4 noexpandtab: */

engines/prince/animation.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ class Animation {
7373
int16 _baseY;
7474
};
7575

76-
}
76+
} // End of namespace Prince
7777

7878
#endif
79-
80-
/* vim: set tabstop=4 noexpandtab: */

engines/prince/archive.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ bool PtcArchive::open(const Common::String &filename) {
6060

6161
_stream->seek(fileTableOffset);
6262

63-
byte *fileTable = new byte[fileTableSize];
63+
byte *fileTable = (byte *)malloc(fileTableSize);
6464
byte *fileTableEnd = fileTable + fileTableSize;
6565
_stream->read(fileTable, fileTableSize);
6666
decrypt(fileTable, fileTableSize);
@@ -73,8 +73,8 @@ bool PtcArchive::open(const Common::String &filename) {
7373
//debug("%12s %8X %d", name.c_str(), item._offset, item._size);
7474
_items[name] = item;
7575
}
76-
77-
delete[] fileTable;
76+
77+
free(fileTable);
7878

7979
return true;
8080
}
@@ -141,6 +141,4 @@ Common::SeekableReadStream *PtcArchive::createReadStreamForMember(const Common::
141141
return new Common::MemoryReadStream(buffer, size, DisposeAfterUse::YES);
142142
}
143143

144-
}
145-
146-
/* vim: set tabstop=4 noexpandtab: */
144+
} // End of namespace Prince

engines/prince/archive.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,3 @@ class PtcArchive : public Common::Archive {
5959
} // End of namespace Prince
6060

6161
#endif
62-
63-
/* vim: set tabstop=4 noexpandtab: */

engines/prince/common.h

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,20 @@
2626
namespace Prince {
2727

2828
enum Direction {
29-
kDirLD = 0,
30-
kDirL = 1,
31-
kDirLU = 2,
32-
kDirRD = 3,
33-
kDirR = 4,
34-
kDirRU = 5,
35-
kDirUL = 6,
36-
kDirU = 7,
37-
kDirUR = 8,
38-
kDirDL = 9,
39-
kDirD = 10,
40-
kDirDR = 11
29+
kDirLD,
30+
kDirL,
31+
kDirLU,
32+
kDirRD,
33+
kDirR,
34+
kDirRU,
35+
kDirUL,
36+
kDirU,
37+
kDirUR,
38+
kDirDL,
39+
kDirD,
40+
kDirDR
4141
};
4242

43-
}
43+
} // End of namespace Prince
4444

4545
#endif
46-
47-
/* vim: set tabstop=4 noexpandtab: */

engines/prince/cursor.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,32 +23,32 @@
2323
#include "prince/cursor.h"
2424

2525
#include "common/debug.h"
26-
#include "common/stream.h"
2726

2827
namespace Prince {
2928

30-
Cursor::Cursor() : _surface(NULL) {
29+
Cursor::Cursor() : _surface(nullptr) {
3130
}
3231

3332
Cursor::~Cursor() {
34-
_surface->free();
35-
delete _surface;
36-
_surface = NULL;
33+
if (_surface != nullptr) {
34+
_surface->free();
35+
delete _surface;
36+
_surface = nullptr;
37+
}
3738
}
3839

3940
bool Cursor::loadFromStream(Common::SeekableReadStream &stream) {
4041
stream.skip(4);
41-
uint16 w = stream.readUint16LE();
42-
uint16 h = stream.readUint16LE();
42+
uint16 width = stream.readUint16LE();
43+
uint16 heigth = stream.readUint16LE();
4344

4445
_surface = new Graphics::Surface();
45-
_surface->create(w, h, Graphics::PixelFormat::createFormatCLUT8());
46+
_surface->create(width, heigth, Graphics::PixelFormat::createFormatCLUT8());
4647

47-
for (int ih = 0; ih < h; ++ih)
48-
stream.read(_surface->getBasePtr(0, ih), w);
48+
for (int h = 0; h < heigth; h++) {
49+
stream.read(_surface->getBasePtr(0, h), width);
50+
}
4951
return true;
5052
}
5153

52-
}
53-
54-
/* vim: set tabstop=4 noexpandtab: */
54+
} // End of namespace Prince

engines/prince/cursor.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@
2525

2626
#include "graphics/surface.h"
2727

28-
namespace Common {
29-
class SeekableReadStream;
30-
}
28+
#include "common/stream.h"
3129

3230
namespace Prince {
3331

@@ -43,8 +41,6 @@ class Cursor {
4341
Graphics::Surface *_surface;
4442
};
4543

46-
}
44+
} // End of namespace Prince
4745

4846
#endif
49-
50-
/* vim: set tabstop=4 expandtab!: */

engines/prince/debugger.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,4 @@ bool Debugger::Cmd_AddItem(int argc, const char **argv) {
171171
return true;
172172
}
173173

174-
}
175-
176-
/* vim: set tabstop=4 noexpandtab: */
174+
} // End of namespace Prince

engines/prince/debugger.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ class Debugger : public GUI::Debugger {
5353
InterpreterFlags *_flags;
5454
};
5555

56-
}
56+
} // End of namespace Prince
5757

5858
#endif
59-
60-
/* vim: set tabstop=4 noexpandtab: */

engines/prince/detection.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,5 +71,3 @@ REGISTER_PLUGIN_DYNAMIC(PRINCE, PLUGIN_TYPE_ENGINE, Prince::PrinceMetaEngine);
7171
#else
7272
REGISTER_PLUGIN_STATIC(PRINCE, PLUGIN_TYPE_ENGINE, Prince::PrinceMetaEngine);
7373
#endif
74-
75-
/* vim: set tabstop=4 noexpandtab: */

0 commit comments

Comments
 (0)