-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipinfo.io gives "Unknown ISP" #511
Comments
Hi @edent , |
The issue doesn't appear to be with our (IPinfo.io)'s data. I also see "Unknown" ISP at https://librespeed.org/ But on https://ipinfo.io I see this So likely the wrong field is being selected, or the request to IPinfo.io is failing, or something similar. |
Yes, looks like the request to IPinfo.io is failing. I see a request to {
"processedString":"12.34.56.78 - Unknown ISP",
"rawIspInfo":null
} So it looks to me like the error is in https://github.com/librespeed/speedtest/blob/master/backend/getIP.php#L107 |
The call to IPinfo.io looks OK. Hve you confirmed |
Is this still an issue? If so what are some fixes for it? |
Description
When running the demo service as https://librespeed.org/ , it reports my ISP as unknown.
Server
https://librespeed.org/
Client
Firefox, Linux. Chrome, Android.
Expected behaviour
ipinfo.io should show the correct ISP.
This might be fixed by using https://ifconfig.co/json - although that might also be out of date.
Or by using a free service like https://ipgeolocation.io/pricing.html - although that has 1,000 request limit per day.
Or by using a static database like https://mailfud.org/geoip-legacy/ - although that will need regular updating.
Let me know if you'd like a PR for any of these fixes.
The text was updated successfully, but these errors were encountered: