Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipinfo.io gives "Unknown ISP" #511

Closed
edent opened this issue Sep 30, 2022 · 5 comments
Closed

ipinfo.io gives "Unknown ISP" #511

edent opened this issue Sep 30, 2022 · 5 comments

Comments

@edent
Copy link

edent commented Sep 30, 2022

Description

When running the demo service as https://librespeed.org/ , it reports my ISP as unknown.

Server

https://librespeed.org/

Client

Firefox, Linux. Chrome, Android.

Expected behaviour

ipinfo.io should show the correct ISP.

This might be fixed by using https://ifconfig.co/json - although that might also be out of date.

Or by using a free service like https://ipgeolocation.io/pricing.html - although that has 1,000 request limit per day.

Or by using a static database like https://mailfud.org/geoip-legacy/ - although that will need regular updating.

Let me know if you'd like a PR for any of these fixes.

@YashRajSingh-4799
Copy link

Hi @edent ,
I am looking to contribute in such a useful website i am new to these web service but i will make sure that i will complete it by learning and enhancing my knowledge.
Please assign me this issue so that i can work on it.
and please let me know if you have any resourses for fixing this issue. Currently i dont know how to fix it but i am curious to know about this new domain of web development to enhance my knowledge

@coderholic
Copy link

The issue doesn't appear to be with our (IPinfo.io)'s data. I also see "Unknown" ISP at https://librespeed.org/

image

But on https://ipinfo.io I see this

image

So likely the wrong field is being selected, or the request to IPinfo.io is failing, or something similar.

@edent
Copy link
Author

edent commented Oct 2, 2022

Yes, looks like the request to IPinfo.io is failing.

I see a request to getIP.php?cors=true&isp=true&distance=km&r=0.6038016549816985 which is returning:

{
   "processedString":"12.34.56.78 - Unknown ISP",
   "rawIspInfo":null
}

So it looks to me like the error is in https://github.com/librespeed/speedtest/blob/master/backend/getIP.php#L107

@coderholic
Copy link

The call to IPinfo.io looks OK. Hve you confirmed getClientIp is getting the right IP?

@czadikem
Copy link

Is this still an issue? If so what are some fixes for it?

@sstidl sstidl closed this as completed in 21fb3c5 Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants