Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting audio quality "best" doesnt actually change the quality best #6058

Open
3 tasks done
pokegamer5547 opened this issue May 19, 2024 · 7 comments
Open
3 tasks done
Labels
bug Something isn't working help wanted Looking for help

Comments

@pokegamer5547
Copy link

Steps to reproduce

Set the audio quality as best in settings

Expected behavior

It should select the one with highest bitrate and quality

Actual behavior

It doean't reapect that and always usea "mp4a.40.2 0kbps" as audio quality. Idk if it's due to HLS.

LibreTube version

0.23.2

Android version

android 13 lineage os 20

Other details

The download button does show higher quality options though.
And the audio source option also doesn't seem to provide any additional options.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@pokegamer5547 pokegamer5547 added the bug Something isn't working label May 19, 2024
@Bnyro Bnyro added the help wanted Looking for help label May 19, 2024
@Bnyro
Copy link
Member

Bnyro commented May 19, 2024

HLS doesn't provide bitrate information apparently, only DASH does. So I don't think we can do anything about it for HLS.

@pokegamer5547
Copy link
Author

HLS doesn't provide bitrate information apparently, only DASH does. So I don't think we can do anything about it for HLS.

That's also true, but how does newpipe used to do it tho? They always said even before DASH got implemented that newpipe app always picked highest bitrate audio.

@pokegamer5547
Copy link
Author

pokegamer5547 commented May 30, 2024

@Bnyro so i followed this comment instructions and disabled piped proxy and use hls and it's still working so i assume since i disabled use hls it's using dash. Yet the bitrate is still low.

@Bnyro
Copy link
Member

Bnyro commented May 30, 2024

Pinging team members is against the code of conduct, first and last warning.

@pokegamer5547
Copy link
Author

Pinging team members is against the code of conduct, first and last warning.

Ah i understand, i'm sorry about that :(

@Bnyro
Copy link
Member

Bnyro commented Jun 2, 2024

disabled piped proxy and use hls and it's still working so i assume since i disabled use hls it's using dash

No, when disabling the Piped proxy HLS is enforced because Dash playback without proxy was broken by YouTube some time ago, see #5524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Looking for help
Projects
None yet
Development

No branches or pull requests

3 participants
@pokegamer5547 @Bnyro and others