feat(swarm): add ConnectionHandler::connection_keep_alive default implementation
#4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just don't want it to take effect if we still have streams.
leonzchang
changed the title
ConnectionHandler::connection_keep_alive default implementation
|
Great! This definitely needs a changelog entry and we need to adjust the docs as well to explain that this is optional. |
| @@ -125,25 +124,23 @@ pub trait ConnectionHandler: Send + 'static { | |||
|
|
|||
| /// Returns until when the connection should be kept alive. | |||
There was a problem hiding this comment.
Sure, what do your think we also change KeepAlive to boolean in #4595
There was a problem hiding this comment.
Sure, what do your think we also change
KeepAliveto boolean in #4595
I think it makes sense. With only two variants, we don't really gain anything from having another type and I cannot see how somebody could misinterpret what true and false mean in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
ConnectionHandler::connection_keep_alivedefault implementation.Related: #4306.
Notes & open questions
Change checklist