Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/gossipsub: Removes an outdated warning #2496

Merged
merged 2 commits into from
Feb 9, 2022
Merged

protocols/gossipsub: Removes an outdated warning #2496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b60277e
Remove old warning
AgeManning Feb 9, 2022
4562c9d
Merge branch 'master' into gossipsub-warning
mxinden Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions protocols/gossipsub/src/peer_score.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,9 +644,9 @@ impl PeerScore {
.entry(msg_id.clone())
.or_insert_with(DeliveryRecord::default);

// this should be the first delivery trace
// Multiple peers can now reject the same message as we track which peers send us the
// message. If we have already updated the status, return.
if record.status != DeliveryStatus::Unknown {
warn!("Unexpected delivery trace: Message from {} was first seen {}s ago and has a delivery status {:?}", from, record.first_seen.elapsed().as_secs(), record.status);
return;
}

Expand Down