Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified handling of idle connections #4306

Closed
6 tasks done
Tracked by #2863
thomaseizinger opened this issue Aug 9, 2023 · 2 comments
Closed
6 tasks done
Tracked by #2863

Simplified handling of idle connections #4306

thomaseizinger opened this issue Aug 9, 2023 · 2 comments
Labels
tracking-issue Issues which are the entry point to bigger projects.

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Aug 9, 2023 •
edited
Loading

Description

For a longer discussion see #3353 (comment).

With #3844, we are deprecating KeepAlive::Until. With #4121, users can configure a Swarm-wide idle timeout that activates once all ConnectionHandlers report KeepAlive::No.

Tasks
Beta Give feedback
  1. swarm: deprecate KeepAlive::Until #3844
    12 of 12
    difficulty:moderate help wanted priority:nicetohave
  2. swarm: Introduce an idle_connection_timeout config option #4121
    difficulty:moderate help wanted
  3. fix(swarm): prevent overflow in keep-alive computation #4559
    send-it
  4. swarm: Default to keeping connections alive whilst there are active streams #4520
    difficulty:moderate help wanted
    leonzchang

Motivation

Easier idle connection management for custom protocols. In particular, most users should not need to deal with idle connections and keep alive tracking but it should just work out of the box.
@thomaseizinger thomaseizinger added this to the Simplify idle connection management milestone Sep 17, 2023
@thomaseizinger thomaseizinger changed the title swarm: rework handling of idle connections Tracking issue for simplified handling of idle connections Sep 19, 2023
@thomaseizinger thomaseizinger removed this from the Simplify idle connection management milestone Sep 19, 2023
@thomaseizinger thomaseizinger changed the title Tracking issue for simplified handling of idle connections Simplified handling of idle connections Sep 19, 2023
@thomaseizinger thomaseizinger added tracking-issue Issues which are the entry point to bigger projects. and removed help wanted difficulty:hard labels Sep 19, 2023
This was referenced Sep 20, 2023
Open
Closed
@mxinden
Copy link
Member

mxinden commented Sep 22, 2023

Thank you for the project management work here!

I am sure #3844 is a good idea. Thus, as you list it above, I suggest landing it first.

#4520 makes sense to me. I haven't put much thought into the concrete implementation that you suggest yet.

@thomaseizinger thomaseizinger mentioned this issue Sep 24, 2023
Closed
@thomaseizinger thomaseizinger mentioned this issue Oct 11, 2023
Merged
4 tasks
@leonzchang leonzchang mentioned this issue Oct 22, 2023
Closed
4 tasks
mergify bot pushed a commit that referenced this issue Oct 25, 2023
@leonzchang
fix(swarm): keep connections alive while active streams exist
fcd410a 
Resolves: #4520.
Related: #4306.

Pull-Request: #4595.
@thomaseizinger
Copy link
Contributor Author

All done! 🥳

@thomaseizinger thomaseizinger mentioned this issue Oct 27, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Oct 30, 2023
@thomaseizinger
refactor(relay): remove explicit stream tracking
35a92df 
With #4306 resolved, we no longer need to carry around oneshots in the relay code that track our alive streams. This is now handled directly by `Connection`.

Pull-Request: #4744.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tracking-issue Issues which are the entry point to bigger projects.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaseizinger @mxinden