Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store protocolVersion and agentVersion in the MetadataBook #799

Closed
Tracked by #3386
vasco-santos opened this issue Nov 12, 2020 · 0 comments · Fixed by #800
Closed
Tracked by #3386

Store protocolVersion and agentVersion in the MetadataBook #799

vasco-santos opened this issue Nov 12, 2020 · 0 comments · Fixed by #800
Assignees
@vasco-santos
Labels
status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

We currently have a hardcoded value for agentVersion and protocolVersion. While these values should be used as defaults, libp2p needs to support receiving the protocolVersion value.

Both these values, should be stored in the MetadataBook, in the same way as when we receive this information from other peers in the identify protocol.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vasco-santos vasco-santos

Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: custom and store self agent version + store self protocol version libp2p/js-libp2p
1 participant
@vasco-santos