-
Notifications
You must be signed in to change notification settings - Fork 510
Closed
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/expertHaving worked on the specific codebase is importantHaving worked on the specific codebase is importantkind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featurestatus/readyReady to be workedReady to be worked
Description
- Version: 0.24
- Platform: All
- Subsystem: Identify
Type: Enhancement
Severity: Medium
Description:
Currently in js-libp2p, if we intended to get the peer multiaddrs, we must get them from libp2p.peerInfo.multiaddrs.
These multiaddrs from peerInfo contain /ipfs/<peer-id> on them, while in go-libp2p they do not. Moreover, this part of the multiaddr should be added by ipfs in case of needed from them, and not in the peer-info.
Modifying this in peer-info will break a lot of stuff upstream, but we will need to change this.
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/expertHaving worked on the specific codebase is importantHaving worked on the specific codebase is importantkind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featurestatus/readyReady to be workedReady to be worked