Skip to content

Commit d72b511

Browse files
maschadachingbrain
andauthored
chore: enable webkit tests in interop (#2541)
Closes #1808 --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
1 parent f049db9 commit d72b511

File tree

5 files changed

+20
-15
lines changed

5 files changed

+20
-15
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ jobs:
231231
- uses: libp2p/test-plans/.github/actions/run-interop-ping-test@master
232232
with:
233233
test-filter: js-libp2p-head
234-
extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json ${{ github.workspace }}/interop/firefox-version.json
234+
extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json ${{ github.workspace }}/interop/firefox-version.json ${{ github.workspace }}/interop/webkit-version.json
235235
s3-cache-bucket: ${{ vars.S3_LIBP2P_BUILD_CACHE_BUCKET_NAME }}
236236
s3-access-key-id: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_ACCESS_KEY_ID }}
237237
s3-secret-access-key: ${{ secrets.S3_LIBP2P_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}

interop/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
image_name := js-libp2p-head
22
TEST_SOURCES := $(wildcard test/*.ts)
33

4-
# Enable webkit once https://github.com/libp2p/js-libp2p/pull/1627 is in
5-
# all: image.json webkit-image.json firefox-image.json chromium-image.json
6-
all: image.json firefox-image.json chromium-image.json
4+
all: image.json firefox-image.json chromium-image.json webkit-image.json
75

86
image.json: Dockerfile $(TEST_SOURCES) package.json .aegir.js
97
cd .. && docker build -f interop/Dockerfile -t node-${image_name} .

interop/webkit-version.json

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
{
2-
"id": "webkit-js-libp2p-head",
3-
"containerImageID": "webkit-js-libp2p-head",
4-
"transports": [],
5-
"secureChannels": [
6-
"noise"
7-
],
8-
"muxers": [
9-
"yamux",
10-
"mplex"
11-
]
12-
}
2+
"id": "webkit-js-libp2p-head",
3+
"containerImageID": "webkit-js-libp2p-head",
4+
"transports": [
5+
{
6+
"name": "webrtc-direct",
7+
"onlyDial": true
8+
},
9+
"webrtc",
10+
{
11+
"name": "wss",
12+
"onlyDial": true
13+
}
14+
],
15+
"secureChannels": ["noise"],
16+
"muxers": ["yamux", "mplex"]
17+
}

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"test:firefox": "aegir run test:firefox",
2222
"test:firefox-webworker": "aegir run test:firefox-webworker",
2323
"test:electron-main": "aegir run test:electron-main",
24+
"test:webkit": "aegir run test:webkit",
2425
"test:cli": "aegir run test:cli",
2526
"test:interop": "aegir run test:interop",
2627
"coverage": "aegir run coverage",

packages/transport-webrtc/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
"test:node": "aegir test -t node --cov -- --exit",
4444
"test:chrome": "aegir test -t browser --cov",
4545
"test:firefox": "aegir test -t browser -- --browser firefox",
46+
"test:webkit": "aegir test -t browser -- --browser webkit",
4647
"lint": "aegir lint",
4748
"lint:fix": "aegir lint --fix",
4849
"clean": "aegir clean",

0 commit comments

Comments
 (0)