This repository was archived by the owner on Jun 15, 2023. It is now read-only.
refactor: use async/await instead of callbacks #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
force-pushed
the
refactor/async-await
branch
from
bbfb00c to
fff701a
Compare
achingbrain
reviewed
Aug 14, 2019
achingbrain
reviewed
Aug 14, 2019
chore: move promisify to dev dep
Contributor
Author
|
👍 nits fixed |
alanshaw
approved these changes
Aug 14, 2019
| */ | ||
| async function findAsync (array, asyncCompare) { | ||
| const promises = array.map(asyncCompare) | ||
| const results = await Promise.all(promises) |
Member
There was a problem hiding this comment.
We have to wait for all these promises to resolve before we can find the value. This is a change in behaviour from async/detect which executes in parallel but will call the callback _as soon as _ one returns true.
...we can leave this for a separate PR.
vasco-santos
suggested changes
Aug 16, 2019
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Looks good! Just pointed some minor stuff mostly regarding jsdocs
src/keychain.js
Outdated
| const kid = await privateKey.id() | ||
| // if (err) return throwDelayed(callback, err) | ||
| const pem = await privateKey.export(this._()) | ||
| // if (err) return throwDelayed(callback, err) |
Member
There was a problem hiding this comment.
Should we remove all the above comments?
We should probably add a try...catch from the const kid line until the commit throwing using the throwDelayed if we catch any error?
Contributor
Author
There was a problem hiding this comment.
Done, I also wrapped renameKey to make sure we're delaying there as well.
Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
vasco-santos
approved these changes
Aug 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The api now uses async/await instead of callbacks.