-
Notifications
You must be signed in to change notification settings - Fork 8
CMS - PKCS #7 #19
Conversation
|
This spec is missing a verification and signing. |
|
Verification requires the keychain to manage public keys. Does verification fail if a public key is missing for a signer? Are multiple signers allowed? |
|
@diasdavid These test are randomly failing because |
|
|
||
| after_success: | ||
| - npm run coverage-publish | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem that coverage got added to Circle https://github.com/libp2p/js-libp2p-keychain/blob/master/circle.yml
|
@richardschneider updated deps and rebased master onto this branch. Mind checking why there are failures? You need a release of keychain with this PR, right? |
|
@diasdavid Thanks for the fast response. No, I just need the current |
|
@diasdavid Its a problem with the latest Please rollback to |
|
@richardschneider is this ready as well? |
|
@diasdavid Yes its RTM. I was just waiting for other stuff to settle down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏽
A proposal for creating cryptographic protected data using the key chain. It uses
PKCS #7 aka RFC 5652to encrypt the data.This can be used to implement
ipfs crypt encryptandipfs crypt decryptin spec keystore