Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Add peers to the kbucket that are still missing #3

Open
daviddias opened this issue Apr 6, 2017 · 0 comments
Open

Add peers to the kbucket that are still missing #3

daviddias opened this issue Apr 6, 2017 · 0 comments
Labels
exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

Currently, there is a window of time after a new dial where a connection will be already established, but the kbucket doesn't know about it yet. A quick solution would be to do peerBook.forEach - if peer.isConnected and added those who missing, but at that time, we can't tell if that peer supports DHT.

What we need is to use the protocols prop available, but for that, we need to start getting that populated from Identify.
@daviddias daviddias added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Apr 6, 2017
@daviddias daviddias added the status/ready Ready to be worked label Jul 27, 2017
@daviddias daviddias added exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up and removed help wanted Seeking public contribution on this issue labels Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daviddias