Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Make optional arguments last #153

Closed
achingbrain opened this issue Jul 10, 2019 · 4 comments · Fixed by #154
Closed

Make optional arguments last #153

achingbrain opened this issue Jul 10, 2019 · 4 comments · Fixed by #154
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue

Comments

@achingbrain
Copy link
Member

Methods like the export from src/keys/rsa-class.js have optional arguments first in their signature. They should be last to follow conventions.

cc @dirkmc

@achingbrain achingbrain added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up labels Jul 10, 2019
@achingbrain achingbrain mentioned this issue Jul 10, 2019
2 tasks
@dirkmc
Copy link
Contributor

dirkmc commented Jul 10, 2019

I'd suggest we do this immediately after the async changes, and before we do a release, as it's a breaking change

@jacobheun
Copy link
Contributor

I agree, since this needs to get pulled into several of the modules, we should make the change before going through that effort.

The only caveat is that it will make those migrations to async/await a little more confusing in PRs moving the params around.

@jacobheun
Copy link
Contributor

async/await is in master, @achingbrain or @dirkmc, do either of you have time to do this? I'm working on a couple of other things but can take this after (likely tomorrow) if neither of you do.

@dirkmc
Copy link
Contributor

dirkmc commented Jul 10, 2019

Sure I can do it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants