Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOTICE: Refactor in progress β€” refrain from updating dependencies #649

Closed
raulk opened this issue May 24, 2019 · 3 comments
Closed
Assignees

Comments

@raulk
Copy link
Member

raulk commented May 24, 2019

We are currently landing a long-awaited refactor across all libp2p repos that will make life significantly easier for everybody πŸŽ‰ Read the details here: #602.

This refactor will be fully backwards-compatible for 99% percent of users.

Due to the way gomod works, and the modular nature of libp2p, this couldn’t be automated.

We are halfway through, and we hope to be finished by Monday 27th May end of day, or sooner.

Until then, please do not upgrade your go-libp2p dependencies, or if you do, only apply patch upgrades (not minor version bumps).

If starting a new project, please use gomod with go-libp2p v0.0.30.

We’ll close this issue when the build is fully consistent again.

Thank you for your cooperation. The result will be worth the tiny pain! πŸ™Œ

@raulk raulk self-assigned this May 24, 2019
@raulk raulk pinned this issue May 24, 2019
@bonedaddy
Copy link

It might be beneficial to disperse this across different channels. I just did a dependency update and absolutely rekt my branch :P

@raulk
Copy link
Member Author

raulk commented May 26, 2019

UPDATE: Codebase-wide refactor is now complete and dependency upgrades should now lead to a consistent build. It's late here and I will do a sanity check tomorrow before I close this issue.

Thanks for your patience! πŸ™

@raulk
Copy link
Member Author

raulk commented May 27, 2019

We have now successfully verified the build is consistent and backwards-compatible. All done here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants