-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process unresponsive to SIGINT #2785
Comments
This issue is that uber fx (a dependency we have to construct the host) will register their own signal handler even if we stop the host. We should be able to fix this once this issue is resolved: uber-go/fx#1197 As a workaround your program can listen for sigint. |
@MarcoPolo I ran into this issue recently. |
Did you stop the host and then do ctrl-c? Can you share a repro? |
I can try to extract an example! |
Yeah. I think you're right. I thought the issue here was that even if the host was stopped we still failed to stop on ctrl-c. But you're right, we should stop the host on ctrl-c as well. The original issue in this thread still fails because the example doesn't stop the host. I'll make that fix now. |
This bug was discovered on the master branch after the merge at
9d149fa3cbba11f2985fbc8e42cd2cf6b9a679f7
Using
./examples/echo
to reproduce, first set libp2p to the problematic version, the process can't be killed with ctrl-cNow downgrade libp2p to its parent commit, the process gets interrupted as expected
The text was updated successfully, but these errors were encountered: