Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test using goleak #2517

Closed
p-shahi opened this issue Aug 24, 2023 · 1 comment
Closed

Add test using goleak #2517

p-shahi opened this issue Aug 24, 2023 · 1 comment
Labels
exp/intermediate Prior experience is likely helpful kind/test Testing work P1 High: Likely tackled by core team if no one steps up

Comments

@p-shahi
Copy link
Member

p-shahi commented Aug 24, 2023 

          Adding a test using goleak seems like a good idea as well.

Originally posted by @marten-seemann in #2514 (comment)

Add a goleak tests to catch issues like #2514
It seems like we have some existing goleak tests in the peerstore

go-libp2p/p2p/host/peerstore/pstoremem/inmem_test.go

Line 78 in 5622bc3

func TestMain(m *testing.M) {

@p-shahi p-shahi added kind/test Testing work P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful labels Aug 24, 2023
@MarcoPolo
Copy link
Collaborator

Done with #2118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful kind/test Testing work P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarcoPolo @p-shahi