Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport tests: flaky TestMoreStreamsThanOurLimits test #2384

Closed
marten-seemann opened this issue Jun 21, 2023 · 3 comments · Fixed by #2410
Closed

transport tests: flaky TestMoreStreamsThanOurLimits test #2384

marten-seemann opened this issue Jun 21, 2023 · 3 comments · Fixed by #2410
Assignees
@MarcoPolo
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

https://github.com/libp2p/go-libp2p/actions/runs/5331320944/jobs/9659013128

=== RUN   TestMoreStreamsThanOurLimits/WebSocket
      transport_test.go:468: 
          	Error Trace:	/home/runner/work/go-libp2p/go-libp2p/p2p/test/transport/transport_test.go:468
          	Error:      	Not equal: 
          	            	expected: 1024
          	            	actual  : 1023
          	Test:       	TestMoreStreamsThanOurLimits/WebSocket
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Jun 21, 2023
@marten-seemann
Copy link
Contributor Author

This test is flaking a lot, and currently responsible for roughly half of our CI failures:
image

@marten-seemann marten-seemann changed the title websocket: flaky TestMoreStreamsThanOurLimits/WebSocket transport tests: flaky TestMoreStreamsThanOurLimits test Jun 28, 2023
@MarcoPolo
Copy link
Collaborator

Let’s skip this test for now

@MarcoPolo
Copy link
Collaborator

Hmm even webtransport flakes here. Let me rethink this test.

@MarcoPolo MarcoPolo mentioned this issue Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo MarcoPolo

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transport integration tests: Make TestMoreStreamsThanOurLimits less flaky libp2p/go-libp2p
2 participants
@MarcoPolo @marten-seemann